Skip to content

Add deserialization tests for BytesThrottleConfig and LoadProfile #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gh-worker-dd-mergequeue-cf854d merged 1 commit into from
Jan 21, 2026
Merged

Add deserialization tests for BytesThrottleConfig and LoadProfile #1684

gh-worker-dd-mergequeue-cf854d merged 1 commit into from
Jan 21, 2026

Conversation

@TheSafo
Copy link
Contributor

@TheSafo TheSafo commented Jan 6, 2026 •
edited
Loading

This is a test-only PR that introduces some tests as an intermediate step before changing deserialization of LoadProfile and BytesThrottleConfig. This way it's easier to verify in #1675 that we didn't break existing configs.

This was referenced Jan 6, 2026
Merged
Merged
@TheSafo Graphite App
Copy link
Contributor Author

TheSafo commented Jan 6, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@TheSafo TheSafo mentioned this pull request Jan 6, 2026
Open
@TheSafo TheSafo changed the title config tests Add deserialization tests for BytesThrottleConfig and LoadProfile Jan 6, 2026
@TheSafo TheSafo force-pushed the jsaf/add-config-tests branch from af8d207 to cf2d888 Compare January 6, 2026 22:13
@TheSafo TheSafo mentioned this pull request Jan 7, 2026
Draft
@TheSafo TheSafo force-pushed the jsaf/add-config-tests branch from cf2d888 to e564637 Compare January 15, 2026 21:34
@TheSafo TheSafo force-pushed the jsaf/throttle-error-change branch from 891a604 to 242e45f Compare January 15, 2026 21:34
@TheSafo TheSafo mentioned this pull request Jan 15, 2026
Merged
@TheSafo TheSafo force-pushed the jsaf/add-config-tests branch from e564637 to a1be97c Compare January 15, 2026 21:35
@TheSafo TheSafo force-pushed the jsaf/throttle-error-change branch from 242e45f to 413e3a8 Compare January 15, 2026 21:35
@TheSafo TheSafo marked this pull request as ready for review January 16, 2026 15:09
@TheSafo TheSafo requested a review from a team as a code owner January 16, 2026 15:09
Base automatically changed from jsaf/throttle-error-change to main January 20, 2026 17:09
@TheSafo
Copy link
Contributor Author

TheSafo commented Jan 20, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Jan 20, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-20 17:30:04 UTC ℹ️ Start processing command /merge

2026-01-20 17:30:10 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 13m (p90).

2026-01-20 17:30:33 UTC ℹ️ MergeQueue: Retrying because an high priority merge request needed to be processed first. No action is needed from your side.

2026-01-20 17:30:37 UTC ⚠️ MergeQueue: This merge request build was cancelled

jake.saferstein@datadoghq.com cancelled this merge request build

@TheSafo
Copy link
Contributor Author

TheSafo commented Jan 20, 2026

/merge -c

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Jan 20, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-20 17:30:25 UTC ℹ️ Start processing command /merge -c

@TheSafo TheSafo force-pushed the jsaf/add-config-tests branch from a1be97c to 47e1784 Compare January 21, 2026 15:48
@TheSafo
Copy link
Contributor Author

TheSafo commented Jan 21, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Jan 21, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-21 15:50:34 UTC ℹ️ Start processing command /merge

2026-01-21 15:51:12 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-01-21 15:58:29 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 13m (p90).

2026-01-21 16:23:06 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 6fd1cf5 into main Jan 21, 2026
38 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the jsaf/add-config-tests branch January 21, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blt blt blt approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done no-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TheSafo @blt