Skip to content

Modify throttle errors to not assume capacity issue #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gh-worker-dd-mergequeue-cf854d merged 2 commits into from
Jan 20, 2026
Merged

Modify throttle errors to not assume capacity issue #1679

gh-worker-dd-mergequeue-cf854d merged 2 commits into from
Jan 20, 2026

Conversation

@TheSafo
Copy link
Contributor

@TheSafo TheSafo commented Jan 5, 2026 •
edited
Loading

Minor change to throttler error handling in the generators so that callers don't assume a capacity issue.

This way, callers don't need to calculate total bytes before the error, which is less applicable for block-based throttling in the follow up change: #1675

https://datadoghq.atlassian.net/browse/EPIN-2527

@TheSafo Graphite App
Copy link
Contributor Author

TheSafo commented Jan 5, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@TheSafo TheSafo changed the title throttler error cleanup Rework throttler error Jan 5, 2026
@TheSafo TheSafo changed the title Rework throttler error Rework throttler erro Jan 5, 2026
@TheSafo TheSafo changed the title Rework throttler erro Modify throttle errors to not assume capacity issue Jan 5, 2026
@TheSafo TheSafo mentioned this pull request Jan 5, 2026
Merged
This was referenced Jan 6, 2026
Open
Merged
@TheSafo TheSafo marked this pull request as ready for review January 7, 2026 19:50
@TheSafo TheSafo requested a review from a team as a code owner January 7, 2026 19:50
@TheSafo TheSafo mentioned this pull request Jan 7, 2026
Draft
@TheSafo TheSafo changed the base branch from main to graphite-base/1679 January 15, 2026 21:33
@TheSafo TheSafo force-pushed the jsaf/throttle-error-change branch from 891a604 to 242e45f Compare January 15, 2026 21:34
@TheSafo TheSafo force-pushed the graphite-base/1679 branch from 7a819ad to 92a7bd0 Compare January 15, 2026 21:34
@TheSafo TheSafo changed the base branch from graphite-base/1679 to jsaf/resize-blocks January 15, 2026 21:34
@TheSafo TheSafo mentioned this pull request Jan 15, 2026
Merged
@TheSafo TheSafo force-pushed the jsaf/resize-blocks branch from 92a7bd0 to f4e7959 Compare January 15, 2026 21:35
@TheSafo TheSafo force-pushed the jsaf/throttle-error-change branch from 242e45f to 413e3a8 Compare January 15, 2026 21:35
Base automatically changed from jsaf/resize-blocks to main January 20, 2026 16:34
@TheSafo
Copy link
Contributor Author

TheSafo commented Jan 20, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Jan 20, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-20 16:57:21 UTC ℹ️ Start processing command /merge

2026-01-20 16:58:03 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 13m (p90).

2026-01-20 17:09:43 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 50b4dd9 into main Jan 20, 2026
58 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the jsaf/throttle-error-change branch January 20, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blt blt blt approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done no-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TheSafo @blt