Skip to content

Also trigger Windows CI on .bazel* changes#48209

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
regis.desgroppes/windows-ci-on-bazelrc-changes
Mar 23, 2026
Merged

Also trigger Windows CI on .bazel* changes#48209
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
regis.desgroppes/windows-ci-on-bazelrc-changes

Conversation

@rdesgroppes
Copy link
Copy Markdown
Contributor

What does this PR do?

Add .bazel* to the windows_path_2 change filter in .gitlab-ci.yml.

Motivation

.bazelrc and .bazelversion live at the repo root, not under bazel/**/*.
Changes to those files can affect Windows builds and tests (#48207) without triggering Windows CI jobs, so
regressions go undetected until the change lands on main.

Follows #48087 - more to come?

@rdesgroppes rdesgroppes requested a review from a team as a code owner March 23, 2026 12:47
@rdesgroppes rdesgroppes added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Mar 23, 2026
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr bot commented Mar 23, 2026

Gitlab CI Configuration Changes

Modified Jobs

workflow (configuration)
  workflow:
    rules:
    - if: $CI_PIPELINE_SOURCE == "trigger" || $CI_PIPELINE_SOURCE == "pipeline"
    - if: $CI_COMMIT_BRANCH == "main"
      variables:
        BAZEL_CACHE_POLICY_SUFFIX: -push
        GO_TEST_SKIP_FLAKE: 'false'
    - if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
    - if: $DEPLOY_AGENT == "true" || $DDR_WORKFLOW_ID != null
    - if: $RUN_E2E_TESTS == "on"
    - if: $DEPLOY_INSTALLER == "true" || $DDR_WORKFLOW_ID != null
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
    - changes:
        compare_to: main
        paths:
        - '**/*_windows.go'
        - pkg/util/winutil/**/*
        - pkg/windowsdriver/**/*
        - pkg/util/pdhutil/**/*
        - pkg/util/crashreport/**/*
        - pkg/collector/corechecks/system/wincrashdetect/**/*
        - pkg/collector/corechecks/system/windowscertificate/**/*
        - pkg/collector/corechecks/system/winkmem/**/*
        - pkg/collector/corechecks/system/winproc/**/*
        - pkg/collector/corechecks/net/wlan/**/*
        - pkg/logs/launchers/windowsevent/**/*
        - pkg/logs/tailers/windowsevent/**/*
        - pkg/logs/util/windowsevent/**/*
        - pkg/network/driver/**/*
        - cmd/agent/**/*
        - cmd/process-agent/**/*
        - cmd/security-agent/**/*
        - cmd/otel-agent/**/*
        - cmd/privateactionrunner/**/*
        - cmd/system-probe/**/*
        - cmd/trace-agent/**/*
        - cmd/installer/**/*
        - cmd/systray/**/*
        - cmd/otel-agent/**/*
      variables:
        SKIP_WINDOWS: 'false'
    - changes:
        compare_to: main
        paths:
        - comp/systray/**/*
        - comp/updater/**/*
        - comp/checks/agentcrashdetect/**/*
        - comp/checks/windowseventlog/**/*
        - comp/checks/winregistry/**/*
        - comp/metadata/hostsysteminfo/**/*
        - comp/trace/etwtracer/**/*
        - comp/etw/**/*
        - comp/notableevents/**/*
        - comp/publishermetadatacache/**/*
        - comp/softwareinventory/**/*
        - tools/windows/**/*
+       - .bazel*
        - MODULE.bazel*
        - omnibus/**/*
        - packages/**/*
        - deps/**/*
        - rtloader/**/*
        - bazel/**/*
        - Dockerfiles/agent/windows/**/*
        - Dockerfiles/agent/entrypoint.ps1
        - Dockerfiles/agent/entrypoint.d.windows/**/*
        - chocolatey/**/*
        - tasks/msi.py
        - tasks/winbuild.py
        - tasks/winbuildscripts/**/*
        - tasks/windows_resources.py
        - tasks/systray.py
        - release.json
        - .gitlab-ci.yml
        - .gitlab/**/*
      variables:
        SKIP_WINDOWS: 'false'
    - changes:
        compare_to: main
        paths:
        - test/new-e2e/tests/fleet/**/*
        - test/new-e2e/tests/installer/windows/**/*
        - test/new-e2e/tests/windows/**/*
        - test/new-e2e/tests/sysprobe-functional/**/*
      variables:
        SKIP_WINDOWS: 'false'
    - if: $CI_COMMIT_TAG == null
      variables:
        SKIP_WINDOWS: 'true'
.windows_path_2
  .windows_path_2:
  - comp/systray/**/*
  - comp/updater/**/*
  - comp/checks/agentcrashdetect/**/*
  - comp/checks/windowseventlog/**/*
  - comp/checks/winregistry/**/*
  - comp/metadata/hostsysteminfo/**/*
  - comp/trace/etwtracer/**/*
  - comp/etw/**/*
  - comp/notableevents/**/*
  - comp/publishermetadatacache/**/*
  - comp/softwareinventory/**/*
  - tools/windows/**/*
+ - .bazel*
  - MODULE.bazel*
  - omnibus/**/*
  - packages/**/*
  - deps/**/*
  - rtloader/**/*
  - bazel/**/*
  - Dockerfiles/agent/windows/**/*
  - Dockerfiles/agent/entrypoint.ps1
  - Dockerfiles/agent/entrypoint.d.windows/**/*
  - chocolatey/**/*
  - tasks/msi.py
  - tasks/winbuild.py
  - tasks/winbuildscripts/**/*
  - tasks/windows_resources.py
  - tasks/systray.py
  - release.json
  - .gitlab-ci.yml
  - .gitlab/**/*

Changes Summary

Removed Modified Added Renamed
0 2 0 0

ℹ️ Diff available in the job log.

@dd-octo-sts dd-octo-sts bot added internal Identify a non-fork PR team/agent-devx labels Mar 23, 2026
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Mar 23, 2026
### What does this PR do?
Add `.bazel*` to the `windows_path_2` change filter in
`.gitlab-ci.yml`.

### Motivation
`.bazelrc` and `.bazelversion` live at the repo root, not under
`bazel/**/*`.
Changes to those files can affect Windows builds and tests (#48207)
without triggering Windows CI jobs, so
regressions go undetected until the change lands on `main`.

Follows #48087 - more to come?
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/windows-ci-on-bazelrc-changes branch from 43d4682 to 66dd802 Compare March 23, 2026 13:01
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 6d7bc6df:

Results for datadog-agent_7.79.0~devel.git.57.66dd802.pipeline.103975786-1_amd64.deb:

No change detected

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit c2e6fac into main Mar 23, 2026
260 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the regis.desgroppes/windows-ci-on-bazelrc-changes branch March 23, 2026 14:39
@github-actions github-actions bot added this to the 7.79.0 milestone Mar 23, 2026
@cit-pr-commenter-54b7da
Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 0b5080f3-76b3-488c-9f7f-c748ecd74bb1

Baseline: bfcf063
Comparison: c2e6fac
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -0.74 [-3.79, +2.31] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +1.54 [+1.39, +1.69] 1 Logs
quality_gate_metrics_logs memory utilization +0.58 [+0.34, +0.81] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization +0.45 [+0.35, +0.55] 1 Logs
otlp_ingest_metrics memory utilization +0.41 [+0.26, +0.56] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.28 [+0.05, +0.50] 1 Logs
quality_gate_idle memory utilization +0.13 [+0.08, +0.18] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency egress throughput +0.05 [-0.45, +0.55] 1 Logs
docker_containers_memory memory utilization +0.04 [-0.04, +0.11] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.03 [-0.36, +0.42] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.02 [-0.41, +0.46] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.09, +0.13] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.01 [-0.19, +0.21] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.20, +0.20] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.02 [-0.13, +0.09] 1 Logs
ddot_metrics memory utilization -0.03 [-0.21, +0.14] 1 Logs
ddot_logs memory utilization -0.07 [-0.12, -0.01] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.12 [-0.19, -0.06] 1 Logs
quality_gate_idle_all_features memory utilization -0.13 [-0.16, -0.09] 1 Logs bounds checks dashboard
file_tree memory utilization -0.16 [-0.21, -0.10] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.26 [-0.40, -0.12] 1 Logs
ddot_metrics_sum_delta memory utilization -0.28 [-0.46, -0.11] 1 Logs
docker_containers_cpu % cpu utilization -0.74 [-3.79, +2.31] 1 Logs
quality_gate_logs % cpu utilization -1.31 [-2.86, +0.24] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 710 ≥ 26
docker_containers_memory memory_usage 10/10 274.28MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 712 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.23GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.21GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle memory_usage 10/10 173.94MiB ≤ 175MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 2 ≤ 3 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 495.84MiB ≤ 550MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 204.12MiB ≤ 220MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 369.21 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 408.25MiB ≤ 475MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

aya-shimizu24 pushed a commit that referenced this pull request Mar 24, 2026
### What does this PR do?
Add `.bazel*` to the `windows_path_2` change filter in `.gitlab-ci.yml`.

### Motivation
`.bazelrc` and `.bazelversion` live at the repo root, not under `bazel/**/*`.
Changes to those files can affect Windows builds and tests (#48207) without triggering Windows CI jobs, so
regressions go undetected until the change lands on `main`.

Follows #48087 - more to come?

Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
rdesgroppes added a commit that referenced this pull request Mar 24, 2026
### What does this PR do?
- add `common:windows --enable_runfiles` to `.bazelrc`
- widen `bazel:test:windows-amd64` from
  `//bazel/tests/... //rtloader/...` to `//...` with exclusions
  for Linux-, eBPF-, and gopatch-only targets

### Motivation
rules_python 1.9.0 (#48082) transitions every `py_binary` and
`py_test` on Windows from `enable_runfiles=auto` to
`enable_runfiles=true`. With Bazel's default (`enable_runfiles=false`
on Windows), this creates a second Bazel configuration, causing
`python_win` to be built twice concurrently. `build_python.bat`
writes MSBuild intermediates to the shared execroot source tree
rather than the action's output directory, so both builds race on
those files, causing intermittent `pyconfig.h` failures.

This is a redo of #48188, which was preemptively reverted (#48207).
Pre-setting `--enable_runfiles` makes the transition a no-op, so
Bazel sees a single configuration and builds `python_win` once.

Two prerequisites are now in place: #48281 provides `PYTHON_FOR_BUILD`
to MSBuild, preventing `find_python.bat` from falling back to NuGet
and other external sources under `--incompatible_strict_action_env`;
#48087 and #48209 trigger Windows CI on `MODULE.bazel*` and `.bazel*`
changes respectively, so the widened test surface below will catch
regressions before they reach `main`.

### Describe how you validated your changes
Local VM and, of course, CI.

### Additional Notes
`//pkg/template/...` is excluded on Windows: gopatch v0.4.0 errors
on `@@\r` in hunk markers when patch files have CRLF line endings,
an unreported upstream bug with no workaround in gopatch itself.
gh-worker-dd-mergequeue-cf854d bot pushed a commit that referenced this pull request Mar 24, 2026
Prior art:
1. #48082
2. #48087
3. #48188 (1st attempt)
4. #48207
5. #48281
6. #48209

### What does this PR do?
This is a redo of #48188 (preemptively reverted by #48207) and therefore merely consists in re-adding `common:windows --enable_runfiles` to `.bazelrc`.

... with lessons learned, thanks to earlier:
- #48209 covers the present change to `.bazelrc`,
- #48281 prevents `find_python.bat` from falling back to `NuGet` or other non hermetic sources.

.... and now a widened `bazel:test:windows-amd64`, evolving from just `//bazel/tests/... //rtloader/...` to `//...` **- except currently failing targets** (for the time being, of course).

### Motivation
Summary of #48188:
- `rules_python` 1.9.0 (#48082) transitions every `py_binary` and `py_test` on Windows from `enable_runfiles=auto` to `enable_runfiles=true`,
- with Bazel's default (`enable_runfiles=false` on Windows), this creates a second Bazel configuration, causing
`python_win` to be built twice concurrently,
- `build_python.bat` writes `MSBuild` intermediates to the shared execroot source tree rather than the action's output directory, so both builds race on those files, causing [intermittent failures](https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1533753039) (`pyconfig.h` not found, etc.).

**Pre-setting `--enable_runfiles` makes the transition a no-op, so Bazel sees a single configuration and builds `python_win` once.**

### Describe how you validated your changes
Local VM and, of course, CI.

### Additional Notes
For instance, `//pkg/template/...` is excluded on Windows because `gopatch` errors on `@@\r` in hunk markers when patch files have CRLF line endings, which deserves a distinct PR (likely adjusting `.gitattributes`).


Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
StephenWakely pushed a commit that referenced this pull request Mar 27, 2026
### What does this PR do?
Add `.bazel*` to the `windows_path_2` change filter in `.gitlab-ci.yml`.

### Motivation
`.bazelrc` and `.bazelversion` live at the repo root, not under `bazel/**/*`.
Changes to those files can affect Windows builds and tests (#48207) without triggering Windows CI jobs, so
regressions go undetected until the change lands on `main`.

Follows #48087 - more to come?

Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
StephenWakely pushed a commit that referenced this pull request Mar 27, 2026
Prior art:
1. #48082
2. #48087
3. #48188 (1st attempt)
4. #48207
5. #48281
6. #48209

### What does this PR do?
This is a redo of #48188 (preemptively reverted by #48207) and therefore merely consists in re-adding `common:windows --enable_runfiles` to `.bazelrc`.

... with lessons learned, thanks to earlier:
- #48209 covers the present change to `.bazelrc`,
- #48281 prevents `find_python.bat` from falling back to `NuGet` or other non hermetic sources.

.... and now a widened `bazel:test:windows-amd64`, evolving from just `//bazel/tests/... //rtloader/...` to `//...` **- except currently failing targets** (for the time being, of course).

### Motivation
Summary of #48188:
- `rules_python` 1.9.0 (#48082) transitions every `py_binary` and `py_test` on Windows from `enable_runfiles=auto` to `enable_runfiles=true`,
- with Bazel's default (`enable_runfiles=false` on Windows), this creates a second Bazel configuration, causing
`python_win` to be built twice concurrently,
- `build_python.bat` writes `MSBuild` intermediates to the shared execroot source tree rather than the action's output directory, so both builds race on those files, causing [intermittent failures](https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1533753039) (`pyconfig.h` not found, etc.).

**Pre-setting `--enable_runfiles` makes the transition a no-op, so Bazel sees a single configuration and builds `python_win` once.**

### Describe how you validated your changes
Local VM and, of course, CI.

### Additional Notes
For instance, `//pkg/template/...` is excluded on Windows because `gopatch` errors on `@@\r` in hunk markers when patch files have CRLF line endings, which deserves a distinct PR (likely adjusting `.gitattributes`).


Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
StephenWakely pushed a commit that referenced this pull request Mar 27, 2026
### What does this PR do?
Add `.bazel*` to the `windows_path_2` change filter in `.gitlab-ci.yml`.

### Motivation
`.bazelrc` and `.bazelversion` live at the repo root, not under `bazel/**/*`.
Changes to those files can affect Windows builds and tests (#48207) without triggering Windows CI jobs, so
regressions go undetected until the change lands on `main`.

Follows #48087 - more to come?

Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
StephenWakely pushed a commit that referenced this pull request Mar 27, 2026
Prior art:
1. #48082
2. #48087
3. #48188 (1st attempt)
4. #48207
5. #48281
6. #48209

### What does this PR do?
This is a redo of #48188 (preemptively reverted by #48207) and therefore merely consists in re-adding `common:windows --enable_runfiles` to `.bazelrc`.

... with lessons learned, thanks to earlier:
- #48209 covers the present change to `.bazelrc`,
- #48281 prevents `find_python.bat` from falling back to `NuGet` or other non hermetic sources.

.... and now a widened `bazel:test:windows-amd64`, evolving from just `//bazel/tests/... //rtloader/...` to `//...` **- except currently failing targets** (for the time being, of course).

### Motivation
Summary of #48188:
- `rules_python` 1.9.0 (#48082) transitions every `py_binary` and `py_test` on Windows from `enable_runfiles=auto` to `enable_runfiles=true`,
- with Bazel's default (`enable_runfiles=false` on Windows), this creates a second Bazel configuration, causing
`python_win` to be built twice concurrently,
- `build_python.bat` writes `MSBuild` intermediates to the shared execroot source tree rather than the action's output directory, so both builds race on those files, causing [intermittent failures](https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1533753039) (`pyconfig.h` not found, etc.).

**Pre-setting `--enable_runfiles` makes the transition a no-op, so Bazel sees a single configuration and builds `python_win` once.**

### Describe how you validated your changes
Local VM and, of course, CI.

### Additional Notes
For instance, `//pkg/template/...` is excluded on Windows because `gopatch` errors on `@@\r` in hunk markers when patch files have CRLF line endings, which deserves a distinct PR (likely adjusting `.gitattributes`).


Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-devx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants