Enable Bazel runfiles on Windows with widened test surface

[rdesgroppes]

Prior art:

1. Bump rules_python to 1.9.0 and fix misuses spotted on Windows #48082
2. Also trigger Windows CI on MODULE.bazel* changes #48087
3. Work around intermittent Windows build failure (missing pyconfig.h, etc.) #48188 (1st attempt)
4. Revert "Work around intermittent Windows build failure (missing pyconfig.h, etc.)" #48207
5. Provide PYTHON_FOR_BUILD to CPython's Windows build #48281
6. Also trigger Windows CI on .bazel* changes #48209

What does this PR do?

This is a redo of #48188 (preemptively reverted by #48207) and therefore merely consists in re-adding common:windows --enable_runfiles to .bazelrc.

... with lessons learned, thanks to earlier:

• Also trigger Windows CI on .bazel* changes #48209 covers the present change to .bazelrc,
• Provide PYTHON_FOR_BUILD to CPython's Windows build #48281 prevents find_python.bat from falling back to NuGet or other non hermetic sources.

.... and now a widened bazel:test:windows-amd64, evolving from just //bazel/tests/... //rtloader/... to //... - except currently failing targets (for the time being, of course).

Motivation

Summary of #48188:

• rules_python 1.9.0 (Bump rules_python to 1.9.0 and fix misuses spotted on Windows #48082) transitions every py_binary and py_test on Windows from enable_runfiles=auto to enable_runfiles=true,
• with Bazel's default (enable_runfiles=false on Windows), this creates a second Bazel configuration, causing
  python_win to be built twice concurrently,
• build_python.bat writes MSBuild intermediates to the shared execroot source tree rather than the action's output directory, so both builds race on those files, causing intermittent failures (pyconfig.h not found, etc.).

Pre-setting --enable_runfiles makes the transition a no-op, so Bazel sees a single configuration and builds python_win once.

Describe how you validated your changes

Local VM and, of course, CI.

Additional Notes

For instance, //pkg/template/... is excluded on Windows because gopatch errors on @@\r in hunk markers when patch files have CRLF line endings, which deserves a distinct PR (likely adjusting .gitattributes).

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0edfae8654

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[agent-platform-auto-pr]

Files inventory check summary

File checks results against ancestor 12568ab7:

Results for datadog-agent_7.79.0~devel.git.113.ebad523.pipeline.104196261-1_amd64.deb:

No change detected

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a51d4669-44d4-4832-ac34-f3859e2616ef

Baseline: f33471b
Comparison: dc389f6
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-3.34	[-6.32, -0.37]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	tcp_syslog_to_blackhole	ingress throughput	+1.53	[+1.38, +1.68]	1	Logs
➖	otlp_ingest_logs	memory utilization	+0.34	[+0.23, +0.46]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.26	[+0.20, +0.32]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.17	[-0.05, +0.39]	1	Logs
➖	ddot_metrics	memory utilization	+0.17	[-0.01, +0.34]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	+0.16	[+0.02, +0.30]	1	Logs
➖	docker_containers_memory	memory utilization	+0.11	[+0.04, +0.19]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.09	[-0.30, +0.48]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.07	[+0.03, +0.10]	1	Logs bounds checks dashboard
➖	file_to_blackhole_0ms_latency	egress throughput	+0.07	[-0.48, +0.62]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.06	[-0.36, +0.49]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.03	[-0.08, +0.14]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.01	[-0.10, +0.12]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.20, +0.19]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	-0.01	[-0.22, +0.19]	1	Logs
➖	file_tree	memory utilization	-0.02	[-0.08, +0.03]	1	Logs
➖	quality_gate_idle	memory utilization	-0.04	[-0.09, +0.01]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	-0.08	[-0.31, +0.15]	1	Logs bounds checks dashboard
➖	otlp_ingest_metrics	memory utilization	-0.30	[-0.47, -0.14]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	-0.46	[-0.63, -0.30]	1	Logs
➖	ddot_logs	memory utilization	-0.68	[-0.73, -0.62]	1	Logs
➖	quality_gate_logs	% cpu utilization	-2.68	[-4.33, -1.04]	1	Logs bounds checks dashboard
➖	docker_containers_cpu	% cpu utilization	-3.34	[-6.32, -0.37]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	720 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	277.97MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	577 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.23GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.21GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 = 3	bounds checks dashboard
❌	quality_gate_idle	memory_usage	9/10	175.17MiB > 175MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	2 ≤ 3	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	498.75MiB ≤ 550MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	204.20MiB ≤ 220MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	361.03 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	409.31MiB ≤ 475MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

❌ Failed. Some Quality Gates were violated.

• quality_gate_idle, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.

[agent-platform-auto-pr]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor c329967
📊 Static Quality Gates Dashboard
🔗 SQG Job

31 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	752.335 MiB
✅	agent_deb_amd64_fips	709.290 MiB
✅	agent_heroku_amd64	313.157 MiB
✅	agent_msi	604.660 MiB
✅	agent_rpm_amd64	752.318 MiB
✅	agent_rpm_amd64_fips	709.274 MiB
✅	agent_rpm_arm64	730.762 MiB
✅	agent_rpm_arm64_fips	690.742 MiB
✅	agent_suse_amd64	752.318 MiB
✅	agent_suse_amd64_fips	709.274 MiB
✅	agent_suse_arm64	730.762 MiB
✅	agent_suse_arm64_fips	690.742 MiB
✅	docker_agent_amd64	812.645 MiB
✅	docker_agent_arm64	815.851 MiB
✅	docker_agent_jmx_amd64	1003.560 MiB
✅	docker_agent_jmx_arm64	995.545 MiB
✅	docker_cluster_agent_amd64	205.320 MiB
✅	docker_cluster_agent_arm64	219.677 MiB
✅	docker_cws_instrumentation_amd64	7.142 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_dogstatsd_amd64	39.230 MiB
✅	docker_dogstatsd_arm64	37.445 MiB
✅	dogstatsd_deb_amd64	29.874 MiB
✅	dogstatsd_deb_arm64	28.026 MiB
✅	dogstatsd_rpm_amd64	29.874 MiB
✅	dogstatsd_suse_amd64	29.874 MiB
✅	iot_agent_deb_amd64	43.262 MiB
✅	iot_agent_deb_arm64	40.309 MiB
✅	iot_agent_deb_armhf	41.052 MiB
✅	iot_agent_rpm_amd64	43.262 MiB
✅	iot_agent_suse_amd64	43.262 MiB

On-wire sizes (compressed)

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	-65.18 KiB (0.04% reduction)	174.743 → 174.679 → 178.360
✅	agent_deb_amd64_fips	-32.18 KiB (0.02% reduction)	165.260 → 165.228 → 172.790
✅	agent_heroku_amd64	+5.98 KiB (0.01% increase)	74.978 → 74.984 → 79.970
✅	agent_msi	-16.0 KiB (0.01% reduction)	138.348 → 138.332 → 146.220
✅	agent_rpm_amd64	+6.21 KiB (0.00% increase)	177.477 → 177.483 → 181.830
✅	agent_rpm_amd64_fips	+17.01 KiB (0.01% increase)	167.420 → 167.436 → 173.370
✅	agent_rpm_arm64	+27.36 KiB (0.02% increase)	159.402 → 159.429 → 163.060
✅	agent_rpm_arm64_fips	+55.56 KiB (0.04% increase)	151.289 → 151.344 → 156.170
✅	agent_suse_amd64	+6.21 KiB (0.00% increase)	177.477 → 177.483 → 181.830
✅	agent_suse_amd64_fips	+17.01 KiB (0.01% increase)	167.420 → 167.436 → 173.370
✅	agent_suse_arm64	+27.36 KiB (0.02% increase)	159.402 → 159.429 → 163.060
✅	agent_suse_arm64_fips	+55.56 KiB (0.04% increase)	151.289 → 151.344 → 156.170
✅	docker_agent_amd64	neutral	268.031 MiB → 272.480
✅	docker_agent_arm64	neutral	255.225 MiB → 261.060
✅	docker_agent_jmx_amd64	neutral	336.686 MiB → 341.100
✅	docker_agent_jmx_arm64	-3.61 KiB (0.00% reduction)	319.869 → 319.865 → 325.620
✅	docker_cluster_agent_amd64	neutral	71.928 MiB → 72.920
✅	docker_cluster_agent_arm64	neutral	67.501 MiB → 68.220
✅	docker_cws_instrumentation_amd64	neutral	2.999 MiB → 3.330
✅	docker_cws_instrumentation_arm64	neutral	2.729 MiB → 3.090
✅	docker_dogstatsd_amd64	neutral	15.169 MiB → 15.820
✅	docker_dogstatsd_arm64	neutral	14.490 MiB → 14.830
✅	dogstatsd_deb_amd64	neutral	7.890 MiB → 8.790
✅	dogstatsd_deb_arm64	neutral	6.776 MiB → 7.710
✅	dogstatsd_rpm_amd64	neutral	7.900 MiB → 8.800
✅	dogstatsd_suse_amd64	neutral	7.900 MiB → 8.800
✅	iot_agent_deb_amd64	neutral	11.396 MiB → 12.040
✅	iot_agent_deb_arm64	neutral	9.698 MiB → 10.450
✅	iot_agent_deb_armhf	neutral	9.935 MiB → 10.620
✅	iot_agent_rpm_amd64	neutral	11.412 MiB → 12.060
✅	iot_agent_suse_amd64	neutral	11.412 MiB → 12.060

[agent-platform-auto-pr]

Gitlab CI Configuration Changes

Modified Jobs

bazel:test:windows-amd64

  bazel:test:windows-amd64:
    before_script:
    - C:\ci-identities-gitlab-job-client.exe assume-role
    id_tokens:
      CI_IDENTITIES_GITLAB_ID_TOKEN:
        aud: ci-identities
    needs: []
    rules:
    - when: on_success
    script:
    - '$FailFast = @''
  
      $ErrorActionPreference = ''Stop''
  
      $PSNativeCommandUseErrorActionPreference = $true
  
      Set-StrictMode -Version 3.0
  
      ''@
  
      Invoke-Expression $FailFast
  
      $Utf8Script = [Text.Encoding]::UTF8.GetString([Text.Encoding]::GetEncoding([Console]::OutputEncoding.CodePage).GetBytes($POWERSHELL_SCRIPT))
  
      $EncodedCommand = [Convert]::ToBase64String([Text.Encoding]::Unicode.GetBytes("$FailFast`n$Utf8Script"))'
    - .\tools\ci\docker-run-with-bazel-cache.ps1 --env=CI_IDENTITIES_GITLAB_ID_TOKEN
      --volume="${CI_PROJECT_DIR}:$CI_PROJECT_DIR" --workdir="$CI_PROJECT_DIR" "$WINBUILDIMAGE"
      powershell -NonInteractive -NoLogo -NoProfile -InputFormat Text -OutputFormat
      Text -EncodedCommand $EncodedCommand
    stage: source_test
    tags:
    - windows-v2:2022
    timeout: 60m
    variables:
      ARCH: x64
      AWS_SHARED_CREDENTIALS_FILE: ${CI_PROJECT_DIR}\.aws\credentials-by-job-id\${CI_JOB_ID}
      BAZELISK_HOME: $XDG_CACHE_HOME/bazelisk
      GIT_DEPTH: 2
      OVERRIDE_GIT_STRATEGY: clone
-     POWERSHELL_SCRIPT: bazel test //bazel/tests/... //rtloader/...
+     POWERSHELL_SCRIPT: bazel test //... -- -//bazel/rules/dd_packaging/... -//internal/tools/modparser:modparser_test
+       -//internal/tools/worksynchronizer:worksynchronizer_test -//packages/agent/linux/...
+       -//pkg/collector/corechecks/ebpf/probe/... -//pkg/dyninst/loader/... -//pkg/dyninst/output/...
+       -//pkg/ebpf/... -//pkg/gpu/ebpf/... -//pkg/network/... -//pkg/networkdevice/profile/profiledefinition/schema:schema_test
+       -//pkg/template/...
      WINBUILDIMAGE: registry.ddbuild.io/ci/datadog-agent-buildimages/windows_ltsc2022_${ARCH}${CI_IMAGE_WIN_LTSC2022_X64_SUFFIX}:${CI_IMAGE_WIN_LTSC2022_X64}
      XDG_CACHE_HOME: c:/bzl

Changes Summary

Removed	Modified	Added	Renamed
0	1	0	0

ℹ️ Diff available in the job log.