Bump rules_python to 1.9.0 and fix misuses spotted on Windows

[rdesgroppes]

What does this PR do?

Bump rules_python from 1.8.5 to 1.9.0 in isolation, as a prerequisite for bumping rules_foreign_cc to a commit that requires its transitive deps to be up-to-date (#48071).

This requires to fix Windows breakages exposed by the bump:

The following shell command exited with status 1:
    $ bazelisk run --//:install_dir=C:/opt/datadog-agent --//packages/agent:flavor=base -- //packages/install_dir:install
Output:
    (nothing)
Error:
[...]
INFO: Running command line: C:/bzl/bazel/bv4fleb2/execroot/_main/bazel-out/x64_windows-fastbuild-ST-591ff087943d/bin/packages/install_dir/install.exe
INFO: Installing to C:/opt/datadog-agent
Traceback (most recent call last):
[...]
File "C:\Users\ContainerAdministrator\AppData\Local\Temp\Bazel.runfiles_heizzvq5\runfiles\rules_python++python+python_3_12_x86_64-pc-windows-msvc\Lib\shutil.py", line 598, in copytree
    with os.scandir(src) as itr:
         ^^^^^^^^^^^^^^^
FileNotFoundError: [WinError 3] The system cannot find the path specified: 'C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\Bazel.runfiles_heizzvq5\\runfiles/_main/packages/install_dir/sources'

(example)

The following shell command exited with status 1:
    $ bazelisk run --//packages/agent:flavor=fips -- @openssl//:install --destdir=C:/opt/datadog-agent
Output:
    (nothing)
Error:
[...]
INFO: Running command line: C:/bzl/bazel/bv4fleb2/execroot/_main/bazel-out/x64_windows-fastbuild-ST-591ff087943d/bin/external/+_repo_rules+openssl/install.exe <args omitted>
INFO: Installing to C:/opt/datadog-agent
Traceback (most recent call last):
[...]
File "C:\Users\ContainerAdministrator\AppData\Local\Temp\Bazel.runfiles_5r0pk0mf\runfiles\rules_python++python+python_3_12_x86_64-pc-windows-msvc\Lib\shutil.py", line 598, in copytree
    with os.scandir(src) as itr:
         ^^^^^^^^^^^^^^^
FileNotFoundError: [WinError 3] The system cannot find the path specified: 'C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\Bazel.runfiles_5r0pk0mf\\runfiles/+_repo_rules+openssl/openssl/ssl'

(example)

Motivation

rules_python 1.9.0 enables runfiles on Windows (👍) for py_binary (bazel-contrib/rules_python#3610) so, where 1.8.5 pointed RUNFILES_DIR at the build-time runfiles directory, 1.9.0 makes bazel run copy the runfiles into a fresh temp directory where Bazel would skip empty directories, logically leading pkg_install's copytree to fail with above FileNotFoundError cases.

Bug (TODOs) surfaced:

1. package_licenses unconditionally included the offers_dir tree artifact in pkg_files but, since ship_source_offer is not declared by any dep (work in progress?), offers_dir is always empty:
   • on Linux and macOS bazel run uses symlinks, so an empty tree is useless but harmless,
   • on Windows the directory is absent from the temp copy => FileNotFoundError.
     The fix consists in excluding offers_dir on Windows all platforms until the work is resumed.
2. the openssl FIPS build on Windows declares out_data_dirs = ["ssl", "lib/ossl-modules", "lib/engines-3"], but ssl/ is empty because --openssldir is set to an absolute path (C:/Program Files/…) outside the Bazel sandbox, so install_ssldirs writes there and leaves the sandbox copy empty => FileNotFoundError.
   The fix drops ssl/ from out_data_dirs on Windows FIPS via the existing fips_windows config setting.

Describe how you validated your changes

Reproduced the failures locally on a Windows VM with rules_python 1.9.0, confirmed the fixes resolve them.

[agent-platform-auto-pr]

Files inventory check summary

File checks results against ancestor 967586c5:

Results for datadog-agent_7.79.0~devel.git.29.06fe616.pipeline.103783640-1_amd64.deb:

No change detected

[agent-platform-auto-pr]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 967586c
📊 Static Quality Gates Dashboard
🔗 SQG Job

31 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	750.956 MiB
✅	agent_deb_amd64_fips	707.935 MiB
✅	agent_heroku_amd64	313.022 MiB
✅	agent_msi	604.280 MiB
✅	agent_rpm_amd64	750.940 MiB
✅	agent_rpm_amd64_fips	707.919 MiB
✅	agent_rpm_arm64	729.263 MiB
✅	agent_rpm_arm64_fips	689.310 MiB
✅	agent_suse_amd64	750.940 MiB
✅	agent_suse_amd64_fips	707.919 MiB
✅	agent_suse_arm64	729.263 MiB
✅	agent_suse_arm64_fips	689.310 MiB
✅	docker_agent_amd64	811.275 MiB
✅	docker_agent_arm64	814.412 MiB
✅	docker_agent_jmx_amd64	1002.190 MiB
✅	docker_agent_jmx_arm64	994.106 MiB
✅	docker_cluster_agent_amd64	205.296 MiB
✅	docker_cluster_agent_arm64	219.677 MiB
✅	docker_cws_instrumentation_amd64	7.142 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_dogstatsd_amd64	39.215 MiB
✅	docker_dogstatsd_arm64	37.445 MiB
✅	dogstatsd_deb_amd64	29.858 MiB
✅	dogstatsd_deb_arm64	28.011 MiB
✅	dogstatsd_rpm_amd64	29.858 MiB
✅	dogstatsd_suse_amd64	29.858 MiB
✅	iot_agent_deb_amd64	43.230 MiB
✅	iot_agent_deb_arm64	40.285 MiB
✅	iot_agent_deb_armhf	41.024 MiB
✅	iot_agent_rpm_amd64	43.231 MiB
✅	iot_agent_suse_amd64	43.231 MiB

On-wire sizes (compressed)

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	-10.21 KiB (0.01% reduction)	174.664 → 174.654 → 178.360
✅	agent_deb_amd64_fips	+29.84 KiB (0.02% increase)	165.232 → 165.261 → 172.790
✅	agent_heroku_amd64	neutral	74.949 MiB → 79.970
✅	agent_msi	-8.0 KiB (0.01% reduction)	138.246 → 138.238 → 146.220
✅	agent_rpm_amd64	-29.93 KiB (0.02% reduction)	177.535 → 177.506 → 181.830
✅	agent_rpm_amd64_fips	+35.73 KiB (0.02% increase)	167.268 → 167.303 → 173.370
✅	agent_rpm_arm64	+23.47 KiB (0.01% increase)	159.535 → 159.558 → 163.060
✅	agent_rpm_arm64_fips	+10.21 KiB (0.01% increase)	151.276 → 151.286 → 156.170
✅	agent_suse_amd64	-29.93 KiB (0.02% reduction)	177.535 → 177.506 → 181.830
✅	agent_suse_amd64_fips	+35.73 KiB (0.02% increase)	167.268 → 167.303 → 173.370
✅	agent_suse_arm64	+23.47 KiB (0.01% increase)	159.535 → 159.558 → 163.060
✅	agent_suse_arm64_fips	+10.21 KiB (0.01% increase)	151.276 → 151.286 → 156.170
✅	docker_agent_amd64	neutral	267.902 MiB → 272.480
✅	docker_agent_arm64	neutral	255.127 MiB → 261.060
✅	docker_agent_jmx_amd64	-2.04 KiB (0.00% reduction)	336.556 → 336.554 → 341.100
✅	docker_agent_jmx_arm64	-3.68 KiB (0.00% reduction)	319.775 → 319.771 → 325.620
✅	docker_cluster_agent_amd64	neutral	71.924 MiB → 72.920
✅	docker_cluster_agent_arm64	neutral	67.508 MiB → 68.220
✅	docker_cws_instrumentation_amd64	neutral	2.999 MiB → 3.330
✅	docker_cws_instrumentation_arm64	neutral	2.729 MiB → 3.090
✅	docker_dogstatsd_amd64	neutral	15.161 MiB → 15.820
✅	docker_dogstatsd_arm64	neutral	14.479 MiB → 14.830
✅	dogstatsd_deb_amd64	neutral	7.887 MiB → 8.790
✅	dogstatsd_deb_arm64	neutral	6.774 MiB → 7.710
✅	dogstatsd_rpm_amd64	neutral	7.897 MiB → 8.800
✅	dogstatsd_suse_amd64	neutral	7.897 MiB → 8.800
✅	iot_agent_deb_amd64	neutral	11.389 MiB → 12.040
✅	iot_agent_deb_arm64	neutral	9.695 MiB → 10.450
✅	iot_agent_deb_armhf	neutral	9.929 MiB → 10.620
✅	iot_agent_rpm_amd64	neutral	11.406 MiB → 12.060
✅	iot_agent_suse_amd64	neutral	11.406 MiB → 12.060

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: fa56dff1-43b4-48a7-afac-cd6aa5001d87

Baseline: 20aa50f
Comparison: f8291f2
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+1.54	[-1.48, +4.57]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+1.54	[-1.48, +4.57]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	+1.28	[+1.04, +1.52]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_delta	memory utilization	+0.47	[+0.30, +0.63]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.27	[+0.23, +0.31]	1	Logs bounds checks dashboard
➖	otlp_ingest_metrics	memory utilization	+0.09	[-0.07, +0.25]	1	Logs
➖	ddot_logs	memory utilization	+0.06	[-0.00, +0.12]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.04	[-0.35, +0.43]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	+0.02	[-0.12, +0.17]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	+0.02	[-0.18, +0.21]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.01	[-0.52, +0.54]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.01	[-0.10, +0.12]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.21, +0.20]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.04	[-0.11, +0.03]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.04	[-0.47, +0.39]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	-0.10	[-0.32, +0.13]	1	Logs
➖	ddot_metrics	memory utilization	-0.13	[-0.30, +0.04]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.13	[-0.19, -0.07]	1	Logs
➖	docker_containers_memory	memory utilization	-0.20	[-0.27, -0.12]	1	Logs
➖	quality_gate_idle	memory utilization	-0.28	[-0.33, -0.23]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	-0.29	[-0.35, -0.23]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.58	[-0.68, -0.48]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-1.17	[-1.31, -1.03]	1	Logs
➖	quality_gate_logs	% cpu utilization	-1.68	[-3.28, -0.07]	1	Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	702 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	276.10MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	592 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.23GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.20GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.22GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 = 3	bounds checks dashboard
❌	quality_gate_idle	memory_usage	9/10	175.23MiB > 175MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	2 ≤ 3	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	491.09MiB ≤ 550MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	205.43MiB ≤ 220MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	340.91 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	411.99MiB ≤ 475MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

❌ Failed. Some Quality Gates were violated.

• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4b2c2f088a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".