Skip to content

Expanding options of PhotoCalibratorProtoDUNESP#122

Draft
vpec0 wants to merge 2 commits intodevelopfrom
feature/vpec_configurable_phot_calibrator
Draft

Expanding options of PhotoCalibratorProtoDUNESP#122
vpec0 wants to merge 2 commits intodevelopfrom
feature/vpec_configurable_phot_calibrator

Conversation

@vpec0
Copy link
Member

@vpec0 vpec0 commented Dec 5, 2025

Adding configurables that allow setting calibration constants channel-by-channel.

Adding channel mapping from the channel number to the index in the containers of the constants. Useful when channel numbering convention is not simply 0 .. number-of-channels.

This feature makes this calibrator more generic and usable in other ProtoDUNEs. Main reason now is to have something to calibrate the PDVD PDS.

@vpec0
Copy link
Member Author

vpec0 commented Dec 5, 2025

Example of how the calibrator service would be configured:

services: {
  ...
  IPhotonCalibrator: {
      BadChannels: []
      SPESizes: [ , ] # SPE amplitude for individual channels
      SPEShifts: [,] # offsets, in units of SPE, can be empty/unset
      ChannelNumbers: [] # offline channel numbers corresponding to the values in the preceding configurables
      service_provider: "PhotonCalibratorServiceProtoDUNESP"
  }
  ...
}

{
//fhicl::Atom<float> SPESize { fhicl::Name("SPESize") };
//fhicl::Atom<float> SPEShift { fhicl::Name("SPEShift") };
fhicl::Sequence<float> SPESizes { fhicl::Name("SPESizes") };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be a problem with a lack of default values here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. I think I will add empty lists as default in the configuration fhicl. I will keep this PR in the draft mode for now. We need somebody to test this. If there's urgent need for this feature for the PD VD production (MC or keepup). I'll give it higher priority.

@vpec0 vpec0 mentioned this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants