Don't use photon calibrator in PDVD data

[vpec0]

Current default settings set OpHitFinder to use PDSP calibrator. This messes up the output of the ophit reco.

This change then allows to remove the PhotonCalibratorServiceProtoDUNESP service from the configuration as well.

[YoannKermaidic]

Hi @vpec0 ,
Good that you look into this.
Can you clarify whether it is best to 1) remove the PDSP calibrator or 2) implement one specific for PDVD?

[lpaulucc]

Thank you!

[lpaulucc]

I have the impression we may need a dedicated OpHitFinder module for PDVD. Not only there are many different PDs with different SPE templates, baselines, etc, we will probably need to correct for saturation effects and I don't know if it will be very straightforward to do it with the default hit finder

[YoannKermaidic]

Got it

[vpec0]

@YoannKermaidic

Can you clarify whether it is best to 1) remove the PDSP calibrator or 2) implement one specific for PDVD?

I think we need to figure out, how to calibrate the channels.

If we run the deconvolution first, that should take care of this. If we reconstruct from the raw waveforms directly, we need a calibrator.

PDSP calibrator offers mechanism to calibrate channel-by-channel. So, ideally, we would only need to ensure proper configuration. However, that mechanism relies on the convention that the channel numbering runs from 0 through the number of channels, which is now not the case for PDVD.

I see two ways around it:
a) update the the PDSP calibrator to have an option to specify channel numbers corresponding to the input SPE constants.
b) make a copy of the calibrator and modify it according to our needs.

[vpec0]

I have just created a draft PR, #122, that modifies the current ProtoDUNE SP calibrator to be usable for our purposes, see option a) in my previous post.

With this one, we could simply set UseCalibrator back to true. But we would need to configure the calibrator service. I think the config would be something like:

services: {
  ...
  IPhotonCalibrator: {
      BadChannels: []
      SPESizes: [ , ] # SPE amplitude for individual channels
      SPEShifts: [,] # offsets, in units of SPE, can be empty/unset
      ChannelNumbers: [] # offline channel numbers corresponding to the values in the preceding configurables
      service_provider: "PhotonCalibratorServiceProtoDUNESP"
  }
  ...
}