Skip to content

Prevent profile manager buttons from submitting form #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DHCross wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

Prevent profile manager buttons from submitting form #320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions app/math-brain/components/ProfileManager.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ export default function ProfileManager({
</div>
) : (
<button
type="button"
onClick={() => handleSaveClick('A')}
disabled={
loading ||
Expand All @@ -154,6 +155,7 @@ export default function ProfileManager({
</div>
) : (
<button
type="button"
onClick={() => handleSaveClick('B')}
disabled={
loading ||
Expand Down Expand Up @@ -246,6 +248,7 @@ export default function ProfileManager({
>
<div className="flex items-start justify-between gap-3">
<button
type="button"
onClick={() => toggleExpanded(profile.id)}
className="flex-1 min-w-0 text-left"
aria-expanded={isExpanded}
Expand All @@ -271,20 +274,23 @@ export default function ProfileManager({
</button>
<div className="flex gap-1 flex-shrink-0">
<button
type="button"
onClick={() => onLoadProfile(profile, 'A')}
className="rounded px-2 py-1 text-xs bg-blue-700/30 text-blue-200 hover:bg-blue-700/40 border border-blue-600/50 transition"
title="Load as Person A"
>
→ A
</button>
<button
type="button"
onClick={() => onLoadProfile(profile, 'B')}
className="rounded px-2 py-1 text-xs bg-purple-700/30 text-purple-200 hover:bg-purple-700/40 border border-purple-600/50 transition"
title="Load as Person B"
>
→ B
</button>
<button
type="button"
onClick={() => handleDeleteClick(profile.id)}
className="rounded px-2 py-1 text-xs bg-rose-700/30 text-rose-200 hover:bg-rose-700/40 border border-rose-600/50 transition"
title="Delete profile"
Expand Down Expand Up @@ -364,12 +370,14 @@ export default function ProfileManager({
</div>
<div className="flex gap-2 justify-end">
<button
type="button"
onClick={() => setShowSaveModal(false)}
className="rounded-md border border-slate-600 bg-slate-700 px-4 py-2 text-sm text-slate-200 hover:bg-slate-600 transition"
>
Cancel
</button>
<button
type="button"
onClick={handleSaveConfirm}
disabled={!saveName.trim()}
className="rounded-md border border-emerald-600 bg-emerald-700 px-4 py-2 text-sm text-white hover:bg-emerald-600 disabled:opacity-50 disabled:cursor-not-allowed transition"
Expand All @@ -393,12 +401,14 @@ export default function ProfileManager({
</p>
<div className="flex gap-2 justify-end">
<button
type="button"
onClick={() => setShowDeleteConfirm(null)}
className="rounded-md border border-slate-600 bg-slate-700 px-4 py-2 text-sm text-slate-200 hover:bg-slate-600 transition"
>
Cancel
</button>
<button
type="button"
onClick={handleDeleteConfirm}
className="rounded-md border border-rose-600 bg-rose-700 px-4 py-2 text-sm text-white hover:bg-rose-600 transition"
>
Expand Down
Loading