feat: added scrypt exchange tx sync + log integration #2949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement full trading support for Scrypt exchange with the same rules as Binance/Kraken - using LIMIT orders with dynamic price tracking. ScryptWebSocketConnection: - Add MessageTypes: NEW_ORDER_SINGLE, EXECUTION_REPORT - Add MessageTypes: MARKET_DATA_SNAPSHOT, SECURITY - Add MessageTypes: ORDER_CANCEL_REQUEST, ORDER_CANCEL_REPLACE_REQUEST ScryptService: - Add trading enums: ScryptOrderStatus, ScryptOrderSide, ScryptOrderType - Add fetchOrderBook() - get orderbook with bids/offers - Add getCurrentPrice() - get best bid/ask price - Add getSecurityInfo() / getMinTradeAmount() - dynamic min amounts - Add placeOrder() with price parameter, default to LIMIT - Add sell() - places LIMIT order at current market price - Add cancelOrder() - cancel existing order - Add editOrder() - update order price (OrderCancelReplaceRequest) - Add getOrderStatus() with price field ScryptAdapter: - Add SELL command with tradeAsset parameter - Add checkSellCompletion() with Binance-like price tracking: - NEW/PARTIALLY_FILLED: compare price, editOrder() if changed - CANCELLED: auto-restart with remaining if >= minAmount - FILLED: aggregate output from all correlation IDs - Add aggregateSellOutput() for multi-order fills
- Add verbose log when order price is unchanged (like Binance) - Parallelize aggregateSellOutput() with Promise.allSettled() - Add failure logging and error handling for partial fetch failures - Throw OrderFailedException if no orders can be fetched
…e-tracking' into feat/yapeal-script-tx
- Add ScryptTradingActions migration for rules 312 (CHF) and 313 (EUR) - Set maximal=1000 to trigger automatic USDT conversion
This was referenced Jan 15, 2026
|
- Implement isBalanceTooLowError with common balance error messages - Add tolerance for float comparison in price tracking to avoid unnecessary order updates due to rounding errors
Collaborator
Code Review: Inkonsistente Enum-VerwendungIn Zeile 227 und 246: t.TransactionType === 'Withdrawal' // String-LiteralSollte sein: t.TransactionType === ScryptTransactionType.WITHDRAWAL // EnumDies ist inkonsistent mit dem Rest des Codes, wo Enums korrekt verwendet werden (z.B. Herkunft: Ursprünglich aus PR #2569 (Scrypt Integration) von @TaprootFreak Risiko: Gering - funktioniert aktuell, aber fragil bei API-Änderungen. Empfehlung: Fix vor Merge oder als Follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Checklist
Pre-Release
Post-Release