feat(scrypt): add trading support for automatic EUR/CHF to USDT conversion #2951
+401
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion Add SELL command to ScryptAdapter for automatic trading when fiat balance exceeds threshold (1000 EUR/CHF). Changes: - Add NEW_ORDER_SINGLE and EXECUTION_REPORT message types to WebSocket - Add trading methods to ScryptService: placeOrder(), sell(), checkTrade() - Add ScryptOrderStatus, ScryptOrderSide, ScryptOrderType enums - Extend ScryptAdapter with SELL command and completion check - Add migration to create Actions and update Rules 312/313 When EUR or CHF balance on Scrypt exceeds 1000, the system automatically places a market sell order to convert to USDT.
|
For SELL trades, outputAmount should be the proceeds (USDT received), not the sold quantity (EUR/CHF). Fixed by multiplying filledQuantity with avgPrice from the execution report. Also fixed migration comments to correctly identify rules: - Rule 312 = Scrypt CHF - Rule 313 = Scrypt EUR
Scrypt uses British spelling 'Cancelled' (double 'l'), not American 'Canceled'. Without this fix, cancelled orders would never be detected and orders could hang indefinitely.
FillAndKill (IOC) cancels unfilled portions immediately, causing partial fills on large orders with limited liquidity. GoodTillCancel keeps the order active until completely filled, allowing checkSellCompletion() to poll until FILLED status.
When a Scrypt sell order is CANCELLED (e.g., partial fill with FillAndKill or exchange-side cancellation): 1. Check remaining quantity 2. If negligible (<0.01): consider order complete 3. Otherwise: place new order with remaining amount 4. Track all correlation IDs via updateCorrelationId() 5. Aggregate output from all orders when finally FILLED This matches the robust retry behavior of CcxtExchangeAdapter used by Binance, MEXC, Kraken, etc.
Collaborator
Author
|
Änderungen wurden in #2949 gemerged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
When EUR or CHF balance on Scrypt exceeds 1000, the LiquidityManagement system automatically triggers a market sell order to convert to USDT. This follows the same pattern used by Binance/MEXC adapters.
New ScryptAdapter command:
sellwith params{"tradeAsset":"USDT"}WebSocket API additions:
NewOrderSingle- Place market/limit ordersExecutionReport- Track order statusTest plan