Closed
Conversation
- Teacher pay calculator - Refer a teacher for serious misconduct - Check the Children's barred list - Access your teaching qualifications - Get a teacher relocation payment
- consistently convert markdown contents to UTF-8 so we don't end up with ASCII in unexpected places - handle (i.e. remove) non-breaking spaces in the UTF-8 string
duncanjbrown
force-pushed
the
new-services
branch
from
6d4472a to
1d85cbe
Compare
gpeng
reviewed
Jul 4, 2023
gpeng
left a comment
gpeng
left a comment
There was a problem hiding this comment.
Thanks for doing this @duncanjbrown. Just a couple of comments. They seem to be in the list already but aren't showing on the deployed site 🤷 For 'Access your teaching qualifications' (and I suppose the same applies for Apply for ITT and Publish) I wonder is there any value in us being able to list the other service names that are in those repos. (I don't mean in this PR, just thinking aloud).
| repo_name: "DFE-Digital/teacher-pay-calculator" | ||
| language: 'ruby' | ||
| docsets: [] | ||
| - name: "Refer a teacher for serious misconduct" |
There was a problem hiding this comment.
This one is already on 120 with a slightly different name. I think the existing entry is correct.
| language: 'ruby' | ||
| docsets: | ||
| - path: 'docs' | ||
| - name: "Access your teaching qualifications" |
Contributor
Author
|
Superseded by #48 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also stop docs breaking builds when they have non-breaking spaces in the title