#16: Make docker build python setup script#17
Conversation
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | ||
| cancel-in-progress: true |
There was a problem hiding this comment.
Cancel in-progress builds when a new push occurs in a PR or on a branch. We should actually use that in other repos (magistrate?) too.
Azure builds in vt have autoCancel so that's fine:
pr:
drafts: false
autoCancel: true
cz4rs
changed the title
Using a repository guarantees consistent state. AFAIK there's no need to download scripts individually.
cwschilly
left a comment
cwschilly
left a comment
There was a problem hiding this comment.
Looks good. Only thing is that some documentation (like how/when to use the docker bake file) might be helpful
Agreed. I'm trying to make it incremental, so bake part is only a scratch at the moment. This PR handles mostly the python setup script. |
| # Clean | ||
| RUN rm -rf $WF_TMP_DIR | ||
| # Run the setup scripts | ||
| RUN --mount=type=bind,rw,source=ci,target=${WF_TMP_DIR} \ |
There was a problem hiding this comment.
Mounting as rw to allow saving customized setup script. Docker discards the written data anyways.
https://docs.docker.com/reference/dockerfile/#run---mounttypebind
There was a problem hiding this comment.
TODO: check if --mount=type=cache can be applied here.
https://docs.docker.com/reference/dockerfile/#run---mounttypecache
| @@ -0,0 +1,88 @@ | |||
|
|
|||
There was a problem hiding this comment.
More work on this in a follow-up issue.
|
@cwschilly I did some additional clean-up, can you please have a look? |
lifflander
left a comment
lifflander
left a comment
There was a problem hiding this comment.
Looks good to me, even though I can't approve it since I created it.
3 participants
Fixes #16