Skip to content

Support ecs/app redis env variables #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nh758 wants to merge 1 commit into from
Closed

Support ecs/app redis env variables #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ab-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,16 @@
* @borrows module:resApi as resApi
*/

// Map Environment Variables for redis. Needed to work with the ecs/app module.
// Keep this before any requires of cote
if (
Object.keys(process.env).every((k) => !k.startsWith("COTE_DISOCOVERY_REDIS"))
Copy link
Collaborator

@johnny-hausman johnny-hausman Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So am I right in interpreting this as saying, "As long as there are no env variables that start with "COTE_DISCOVERY_REDIS", then make sure these COTE env variables are set?

What if only 1 or two are set? Do we need to account for that?

I was just looking at my setup, and I only have COTE_DISCOVERY_REDIS_HOST set. If any of our SESSION_REDIS_* values are set, shouldn't those ALWAYS map to the COTE_* values?

Copy link
Contributor Author

@nh758 nh758 Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do it that way. I don’t have a preference either way.
My thought was to do it this way so as not to interfere with existing deployments which will have set at least one COTE_DISCOVERY_REDIS param. But they wouldn’t have SESSION_REDIS_* set either.

Since we’re using a terraform module to set up the ecs app, will always get these 3 SESSION_REDIS params so I don’t think we need to account for that.

) {
process.env.COTE_DISCOVERY_REDIS_HOST = process.env.SESSION_REDIS_HOST;
process.env.COTE_DISCOVERY_REDIS_PORT = process.env.SESSION_REDIS_PORT;
process.env.COTE_DISCOVERY_REDIS_DB = process.env.SESSION_REDIS_DB_INDEX;
}

const config = require("./utils/config.js");
const controller = require("./utils/controller.js");
const defaults = require("./utils/defaults.js");
Expand Down
Loading
Loading