Support ecs/app redis env variables #76
Conversation
|
Please add a release label: |
| // Map Environment Variables for redis. Needed to work with the ecs/app module. | ||
| // Keep this before any requires of cote | ||
| if ( | ||
| Object.keys(process.env).every((k) => !k.startsWith("COTE_DISOCOVERY_REDIS")) |
There was a problem hiding this comment.
So am I right in interpreting this as saying, "As long as there are no env variables that start with "COTE_DISCOVERY_REDIS", then make sure these COTE env variables are set?
What if only 1 or two are set? Do we need to account for that?
I was just looking at my setup, and I only have COTE_DISCOVERY_REDIS_HOST set. If any of our SESSION_REDIS_* values are set, shouldn't those ALWAYS map to the COTE_* values?
There was a problem hiding this comment.
We could do it that way. I don’t have a preference either way.
My thought was to do it this way so as not to interfere with existing deployments which will have set at least one COTE_DISCOVERY_REDIS param. But they wouldn’t have SESSION_REDIS_* set either.
Since we’re using a terraform module to set up the ecs app, will always get these 3 SESSION_REDIS params so I don’t think we need to account for that.
|
We can set these in terraform |
When using the terraform ecs/app module we get ENV variables to connect with the redis (elasticache) instance.
Here I’m mapping the ENV variables we will get to what cote is expecting.
Note this includes an update to cote, as the underlying redis library switched from
node-redistoioredis, which is configured slightly differently. Specifically the DB number.