Open
Conversation
This was
linked to
issues
Jan 13, 2026
HatemMn
force-pushed
the
feat/aws_byok
branch
3 times, most recently
from
7d16d1b to
9b2cd4c
Compare
HatemMn
force-pushed
the
feat/aws_byok
branch
from
9b2cd4c to
982234f
Compare
Contributor
Author
|
@copilot search this PR for "TODO" comments, useless comments, or stuff I have "forgot" around |
Contributor
HatemMn
added
bug
Contributor
Author
|
Documentation isn't finished yet but it's just a matter of redaction The CLI, the UI, and the integration tests are all finished tho For now the only problem here is that, for some reason, when using an algorithm other that RSAES_OAEP_SHA_256 to wrap the AWS KMS returns an "invalid cyphertext error"... Until this is fixed I can safely say that RSAES_OAEP_SHA_256 wrapping is correctly implemented if an AWS BYOK use case is needed by someone, but please don't use the other ones before this is finished |
HatemMn
removed
bug
fix: more work fix: more work2 fix: restore cli commands(I have no idea where that disappeared) fix: fix some docs fix: stuff
HatemMn
force-pushed
the
feat/aws_byok
branch
from
d3d79e0 to
8748da3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce 2 cli actions to permit BYOK flows with AWS KMS (docs below)
Create full flow integration tests - to avoid static mocks, utility functions that mimic (a correct) AWS KMS were created to run locally using openssl
Fix stdout console formatting when an export action happens
Checklist
References :
Creating keys on amazon kms : https://docs.aws.amazon.com/kms/latest/developerguide/importing-keys-conceptual.html
Importing keys https://docs.aws.amazon.com/kms/latest/developerguide/importing-keys.html
Requirements for key material :https://docs.aws.amazon.com/kms/latest/developerguide/importing-keys-conceptual.html#importing-keys-material-requirements