Skip to content

Comments

fix(ui): Azure BYOK export#697

Merged
Manuthor merged 2 commits intodevelopfrom
fix/ui_azure_byok
Jan 29, 2026
Merged

fix(ui): Azure BYOK export#697
Manuthor merged 2 commits intodevelopfrom
fix/ui_azure_byok

Conversation

@Manuthor
Copy link
Contributor

@Manuthor Manuthor commented Jan 29, 2026

The KMIP GetAttributes operation do not retrieve tags except if request ask for them.
The goal of this PR is to add a new WASM function to explicitely request tags to be returned in UI.

@Manuthor Manuthor requested a review from HatemMn January 29, 2026 09:20
@HatemMn HatemMn self-assigned this Jan 29, 2026
Copy link
Contributor

@HatemMn HatemMn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for solving this silent problem !

My comments are mostly for "clean coding" sake and you can immediatly merge without addressing them, but if you do so assign me to do it on the AWS PR as said below

lgtm otherwise - will rebase upon it

@Manuthor Manuthor merged commit 8fd5dda into develop Jan 29, 2026
172 checks passed
@Manuthor Manuthor deleted the fix/ui_azure_byok branch January 29, 2026 13:52
@Manuthor Manuthor mentioned this pull request Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants