Open
Conversation
NickLaMuro
added a commit
to NickLaMuro/manageiq
that referenced
this pull request
Nov 16, 2020
There is currently an outstanding PR for the graphql-preload to support Rails 6: ConsultingMD/graphql-preload#32 So this is currently the simplest option available to us to support this gem.
NickLaMuro
added a commit
to NickLaMuro/manageiq
that referenced
this pull request
Nov 17, 2020
There is currently an outstanding PR for the graphql-preload to support Rails 6: ConsultingMD/graphql-preload#32 So this is currently the simplest option available to us to support this gem.
NickLaMuro
added a commit
to NickLaMuro/manageiq
that referenced
this pull request
Nov 23, 2020
There is currently an outstanding PR for the graphql-preload to support Rails 6: ConsultingMD/graphql-preload#32 So this is currently the simplest option available to us to support this gem.
NickLaMuro
added a commit
to NickLaMuro/manageiq
that referenced
this pull request
Nov 30, 2020
There is currently an outstanding PR for the graphql-preload to support Rails 6: ConsultingMD/graphql-preload#32 So this is currently the simplest option available to us to support this gem.
NickLaMuro
added a commit
to NickLaMuro/manageiq
that referenced
this pull request
Dec 1, 2020
There is currently an outstanding PR for the graphql-preload to support Rails 6: ConsultingMD/graphql-preload#32 So this is currently the simplest option available to us to support this gem.
NickLaMuro
added a commit
to NickLaMuro/manageiq
that referenced
this pull request
Dec 2, 2020
There is currently an outstanding PR for the graphql-preload to support Rails 6: ConsultingMD/graphql-preload#32 So this is currently the simplest option available to us to support this gem.
|
Is there anything blocking you from merging this? Tagging some people I believe having permissions to merge: @RoryO @wyattEpp @thiagofelix Currently |
Contributor
|
I am sorry I have not been associated with this for over a year. @cobbr2 may be able to find someone to help. |
|
I haven't work here for quite some time as well. Looking at the changes apparently we are changing considerably the library behavior so I am not sure if I can approve it confidently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27
Tested in production, also there are tests in my fork here: https://github.com/Envek/graphql-preload