Add basic tests to help in gem maintenance#14
Closed
Envek wants to merge 5 commits intoConsultingMD:masterfrom
Closed
Add basic tests to help in gem maintenance#14Envek wants to merge 5 commits intoConsultingMD:masterfrom
Envek wants to merge 5 commits intoConsultingMD:masterfrom
Conversation
This was referenced Dec 19, 2019
Closed
Author
|
Refreshed this pull request. Added testing against various versions of graphql-ruby (with appraisal) and activerecord (with just an environment variable). You can see it in action in my fork: https://travis-ci.org/github/Envek/graphql-preload/builds/667203000 To make it all pass following pull requests should be also accepted: #25 and #32 |
|
This pull request has been closed because it has not had recent activity. |
Author
|
This pull request is still waiting for review and some feedback from maintainers :-/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we're using this gem in production it is crucial to keep it stable and easy for future improvements.