Restore previous syntax for declaring preload with definition blocks#15
Closed
Envek wants to merge 1 commit intoConsultingMD:masterfrom
Closed
Restore previous syntax for declaring preload with definition blocks#15Envek wants to merge 1 commit intoConsultingMD:masterfrom
Envek wants to merge 1 commit intoConsultingMD:masterfrom
Conversation
|
Can this pull request be merged? It's the only thing prevent us from upgrading to the latest version of Graphql 1.8. Including this backwards compatability fits with the spirit of version 1.8 and the ability to upgrade over time. http://graphql-ruby.org/schema/class_based_api |
|
This pull request has been closed because it has not had recent activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current examples in README.md are based on the syntax of graphql gem DSL before version 1.8.
After #11 was merged these examples aren't working anymore as currently, only modern syntax supported that use options hashes for DSL methods, like this:
I personally like old-fashioned definition blocks more. Especially for long things like descriptions:
In this PR I'm restoring old syntax so both above examples can be used interchangeably and even can be mixed together.
See related discussion starting from #11 (comment)
@RoryO, can you please take a look? If #14 will be merged first I will be glad to add specs for this syntax too.