Skip to content

Refactor node show argument to use Enum for better validation and clarity #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bigcat88 merged 2 commits into from
Jan 7, 2026
Merged

Refactor node show argument to use Enum for better validation and clarity #346

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8740edb
Refactor show command argument to use Enum for improved clarity and v…
Xyc2016 Jan 6, 2026
33af812
Refactor simple-show command argument to use Enum for improved clarit…
Xyc2016 Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 18 additions & 34 deletions comfy_cli/command/custom_nodes/command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import subprocess
import sys
import uuid
from enum import Enum
from typing import Annotated, Optional

import typer
Expand Down Expand Up @@ -36,6 +37,17 @@
registry_api = RegistryAPI()


# Enum for show command target
class ShowTarget(str, Enum):
INSTALLED = "installed"
ENABLED = "enabled"
NOT_INSTALLED = "not-installed"
DISABLED = "disabled"
ALL = "all"
SNAPSHOT = "snapshot"
SNAPSHOT_LIST = "snapshot-list"


def validate_comfyui_manager(_env_checker):
manager_path = _env_checker.get_comfyui_manager_path()

Expand Down Expand Up @@ -304,9 +316,8 @@ def validate_mode(mode):
@app.command(help="Show node list")
@tracking.track_command("node")
def show(
arg: str = typer.Argument(
help="[installed|enabled|not-installed|disabled|all|snapshot|snapshot-list]",
autocompletion=show_completer,
arg: ShowTarget = typer.Argument(
help="Target to display",
),
channel: Annotated[
Optional[str],
Expand All @@ -322,30 +333,16 @@ def show(
autocompletion=mode_completer,
),
):
valid_commands = [
"installed",
"enabled",
"not-installed",
"disabled",
"all",
"snapshot",
"snapshot-list",
]
if arg not in valid_commands:
typer.echo(f"Invalid command: `show {arg}`", err=True)
raise typer.Exit(code=1)

validate_mode(mode)

execute_cm_cli(["show", arg], channel=channel, mode=mode)
execute_cm_cli(["show", arg.value], channel=channel, mode=mode)


@app.command("simple-show", help="Show node list (simple mode)")
@tracking.track_command("node")
def simple_show(
arg: str = typer.Argument(
help="[installed|enabled|not-installed|disabled|all|snapshot|snapshot-list]",
autocompletion=show_completer,
arg: ShowTarget = typer.Argument(
help="Target to display",
),
channel: Annotated[
Optional[str],
Expand All @@ -361,22 +358,9 @@ def simple_show(
autocompletion=mode_completer,
),
):
valid_commands = [
"installed",
"enabled",
"not-installed",
"disabled",
"all",
"snapshot",
"snapshot-list",
]
if arg not in valid_commands:
typer.echo(f"Invalid command: `show {arg}`", err=True)
raise typer.Exit(code=1)

validate_mode(mode)

execute_cm_cli(["simple-show", arg], channel=channel, mode=mode)
execute_cm_cli(["simple-show", arg.value], channel=channel, mode=mode)


# install, reinstall, uninstall
Expand Down