Skip to content

Conversation

@Xyc2016
Copy link
Contributor

@Xyc2016 Xyc2016 commented Jan 6, 2026

Refactor node show argument to use a typed Enum instead of a raw string.

  • Replace manual string validation with ShowTarget(StrEnum)
  • Improve CLI validation and error message clarity

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Jan 6, 2026
@Xyc2016 Xyc2016 force-pushed the improve-node-show branch from c211c48 to abcaba3 Compare January 6, 2026 13:27
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
comfy_cli/command/custom_nodes/command.py 81.81% 2 Missing ⚠️
@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
+ Coverage   52.11%   52.35%   +0.24%     
==========================================
  Files          32       32              
  Lines        3527     3528       +1     
==========================================
+ Hits         1838     1847       +9     
+ Misses       1689     1681       -8     
Files with missing lines Coverage Δ
comfy_cli/command/custom_nodes/command.py 43.34% <81.81%> (+2.24%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Xyc2016
Copy link
Contributor Author

Xyc2016 commented Jan 6, 2026

The failing CI checks are not caused by this PR.
They fail during ComfyUI dependency resolution on Python 3.9 (comfy-kitchen requires >=3.10).

@bigcat88
Copy link
Contributor

bigcat88 commented Jan 7, 2026

@Xyc2016 can you please rebase this PR on main? I had removed python3.9 from the CI.

@bigcat88 bigcat88 self-requested a review January 7, 2026 06:42
@Xyc2016 Xyc2016 force-pushed the improve-node-show branch from abcaba3 to 33af812 Compare January 7, 2026 07:30
Copy link
Contributor

@bigcat88 bigcat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this refactoring! Merging

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 7, 2026
@bigcat88 bigcat88 merged commit 780be2d into Comfy-Org:main Jan 7, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants