Skip to content

ISCDETS-34390: Making Thread Safe task updates for the same task at the same time #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sarmuru2 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ISCDETS-34390: Making Thread Safe task updates for the same task at the same time #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 41 additions & 1 deletion core/src/main/java/com/netflix/conductor/service/ExecutionService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@
import java.util.Map;
import java.util.Objects;
import java.util.Optional;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.locks.Lock;
import java.util.concurrent.locks.ReentrantLock;
import java.util.stream.Collectors;

import org.slf4j.Logger;
Expand Down Expand Up @@ -73,6 +76,9 @@ public class ExecutionService {
private static final int POLL_COUNT_ONE = 1;
private static final int POLLING_TIMEOUT_IN_MS = 100;

private Integer globalLock = Integer.valueOf(1);
private ConcurrentHashMap<String, Lock> taskLocksMap = new ConcurrentHashMap();

public ExecutionService(
WorkflowExecutor workflowExecutor,
ExecutionDAOFacade executionDAOFacade,
Expand Down Expand Up @@ -258,8 +264,42 @@ public void updateTask(Task task) {
updateTask(new TaskResult(task));
}

/*
Introduced locking to avoid parallel task updates for the same task. We faced an issue in conductor when two
threads are updating the same task status as COMPLETED and IN_PROGRESS. Both these updates went successful
where IN_PROGRESS after COMPLETED should fail. As IN_PROGRESS went successful, task is TIMED_OUT after sometime
as there are no further updates from fusion. Workflow TIMED_OUT notification sent to fusion which makes the workflow as
Copy link

@Vikramarjuna Vikramarjuna Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let the comment be generic and not add any fusion details here

TIMED_OUT even though its successfully completed.
*/
public void updateTask(TaskResult taskResult) {
workflowExecutor.updateTask(taskResult);
if (taskResult.getTaskId() == null) {
LOGGER.error(
"Invalid task id in TaskResult. TaskStatus {} workflow id {}",
taskResult.getStatus(),
taskResult.getWorkflowInstanceId());
return;
}
Lock taskLock = null;
synchronized (globalLock) {
taskLock = taskLocksMap.get(taskResult.getTaskId());
if (taskLock == null) {
taskLock = new ReentrantLock();
taskLocksMap.put(taskResult.getTaskId(), taskLock);
}
}
taskLock.lock();
LOGGER.debug("Lock Successfully obtained for {}", taskResult.getTaskId());
try {
workflowExecutor.updateTask(taskResult);
} finally {
if (taskLock != null) {
taskLock.unlock();
LOGGER.debug("Releasing lock for {}", taskResult.getTaskId());
synchronized (globalLock) {
taskLocksMap.remove(taskResult.getTaskId());
}
}
}
}

public List<Task> getTasks(String taskType, String startKey, int count) {
Expand Down