ISCDETS-34390: Making Thread Safe task updates for the same task at the same time #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vikramarjuna
reviewed
Nov 2, 2023
| Introduced locking to avoid parallel task updates for the same task. We faced an issue in conductor when two | ||
| threads are updating the same task status as COMPLETED and IN_PROGRESS. Both these updates went successful | ||
| where IN_PROGRESS after COMPLETED should fail. As IN_PROGRESS went successful, task is TIMED_OUT after sometime | ||
| as there are no further updates from fusion. Workflow TIMED_OUT notification sent to fusion which makes the workflow as |
There was a problem hiding this comment.
let the comment be generic and not add any fusion details here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple task updates done on the same task at the same time, its possible that a racing condition could occur. When IN_PROGRESS and COMPLETED task updates are processed at the same time, its possible that IN_PROGRESS state is updated to task even after conductor updating COMPLETED state. Ideally if there is IN_PROGRESS notification, after COMPLETED notification, it should fail and log error. But in this case, IN_PROGRESS update is through after COMPLETED update and after some time it throws task TIMED_OUT error.