Skip to content

[minor_change] Add mso_fabric_policies_node_settings resource and datasource. (DCNE-648)#451

Open
samiib wants to merge 5 commits intoCiscoDevNet:masterfrom
samiib:node_settings
Open

[minor_change] Add mso_fabric_policies_node_settings resource and datasource. (DCNE-648)#451
samiib wants to merge 5 commits intoCiscoDevNet:masterfrom
samiib:node_settings

Conversation

@samiib
Copy link
Copy Markdown
Collaborator

@samiib samiib commented Feb 24, 2026

Fixes #418

@samiib samiib self-assigned this Feb 24, 2026
@github-actions github-actions bot changed the title [minor_change] Add mso_fabric_policies_node_settings resource and datasource. [minor_change] Add mso_fabric_policies_node_settings resource and datasource. (DCNE-648) Feb 24, 2026
@samiib samiib marked this pull request as ready for review February 24, 2026 06:38
sajagana
sajagana previously approved these changes Feb 26, 2026
Copy link
Copy Markdown
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akinross akinross self-requested a review March 5, 2026 19:30
akinross
akinross previously approved these changes Mar 5, 2026
Copy link
Copy Markdown
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol previously approved these changes Mar 10, 2026
Copy link
Copy Markdown
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samiib samiib dismissed stale reviews from gmicol, akinross, and sajagana via 389bcb4 March 11, 2026 14:13
@samiib samiib requested review from akinross, gmicol and sajagana March 11, 2026 14:13
akinross
akinross previously approved these changes Mar 17, 2026
Copy link
Copy Markdown
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samiib samiib requested a review from mtarking April 6, 2026 23:46
Copy link
Copy Markdown
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement: New Resource and Datasource for Node Settings in Fabric Policy Template (DCNE-648)

5 participants