Skip to content

Addition of resource and data source for tenant_policies_l3out_node_routing_policy (DCNE-286)#413

Open
shrsr wants to merge 4 commits intoCiscoDevNet:masterfrom
shrsr:l3_nrp
Open

Addition of resource and data source for tenant_policies_l3out_node_routing_policy (DCNE-286)#413
shrsr wants to merge 4 commits intoCiscoDevNet:masterfrom
shrsr:l3_nrp

Conversation

@shrsr
Copy link
Copy Markdown
Collaborator

@shrsr shrsr commented Jan 22, 2026

No description provided.

@shrsr shrsr self-assigned this Jan 22, 2026
@shrsr shrsr changed the title Addition of resource and data source for tenant_policies_l3out_node_routing_policy Addition of resource and data source for tenant_policies_l3out_node_routing_policy (DCNE-286) Jan 22, 2026
akinross
akinross previously approved these changes Jan 23, 2026
Copy link
Copy Markdown
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shrsr shrsr requested a review from samiib March 4, 2026 14:35
samiib
samiib previously approved these changes Mar 4, 2026
Copy link
Copy Markdown
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross previously approved these changes Mar 5, 2026
Copy link
Copy Markdown
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana previously approved these changes Mar 6, 2026
Copy link
Copy Markdown
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lhercot
lhercot previously approved these changes Mar 7, 2026
Copy link
Copy Markdown
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib previously approved these changes Mar 10, 2026
Copy link
Copy Markdown
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it still looks like you have merge conflicts again.

Copy link
Copy Markdown
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Description: "BGP Best Path Control - AS path multipath relax. Allows load balancing across paths with different AS paths.",
},
"bfd_multi_hop_settings": {
Type: schema.TypeList,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you use TypeList instead of using TypeMap?

},
},
"bgp_node_settings": {
Type: schema.TypeList,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you use TypeList instead of using TypeMap?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a resource and data source for "L3Out Node Routing Policy" object under Tenant Policies (DCNE-286)

5 participants