Skip to content

Require ci-extended pass for workflow and infrastructure PRs #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chris0Jeky merged 3 commits into from
Mar 31, 2026
Merged

Require ci-extended pass for workflow and infrastructure PRs #642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0bac503
Add *.csproj path trigger to ci-extended workflow
Chris0Jeky Mar 31, 2026
bacface
Add CI Extended validation reminder to PR template
Chris0Jeky Mar 31, 2026
51a4951
Document CI Extended requirement for infrastructure PRs in AGENTS.md
Chris0Jeky Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@
- [ ] Linked issue included (e.g., `Closes #123`)
- [ ] Linked issue’s project item status reviewed (`Review` while this PR is open, `Done` when this PR is merged)

## CI Workflow Validation

- [ ] If this PR touches `.github/workflows/`, `deploy/`, `scripts/`, or `*.csproj` files: confirm CI Extended passed (auto-triggered on these paths)
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The list of paths that trigger CI Extended is incomplete. According to the PR summary, backend/ and frontend/ paths also trigger this workflow. Additionally, the glob pattern should be **/*.csproj to accurately reflect that project files in subdirectories (like backend/src/...) are included in the trigger.

Suggested change
- [ ] If this PR touches `.github/workflows/`, `deploy/`, `scripts/`, or `*.csproj` files: confirm CI Extended passed (auto-triggered on these paths)
- [ ] If this PR touches `.github/workflows/`, `deploy/`, `scripts/`, `backend/`, `frontend/`, or `**/*.csproj` files: confirm CI Extended passed (auto-triggered on these paths)


## Risk Notes

- Security impact:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-extended.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ on:
- frontend/**
- deploy/**
- scripts/**
- '**/*.csproj'
workflow_dispatch:

permissions:
Expand Down
1 change: 1 addition & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ Its scope applies to the entire repo unless overridden by more specific `AGENTS.
- Pull requests: Provide a short summary, key implementation notes, and testing evidence
(commands run, screenshots for UI changes). Link related issues/tasks where applicable.
- Keep PRs focused and small when possible; prefer follow-up PRs for refactors or additional cleanup.
- PRs touching CI workflows (`.github/workflows/`), infrastructure (`deploy/`, `scripts/`), or project files (`*.csproj`) auto-trigger CI Extended. Ensure CI Extended is green before merging these PRs.
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This documentation should include backend/ and frontend/ as they also trigger CI Extended according to the PR description. Also, using the explicit glob **/*.csproj is clearer for agents and matches the implementation described in the PR summary.

Suggested change
- PRs touching CI workflows (`.github/workflows/`), infrastructure (`deploy/`, `scripts/`), or project files (`*.csproj`) auto-trigger CI Extended. Ensure CI Extended is green before merging these PRs.
- PRs touching CI workflows (`.github/workflows/`), infrastructure (`deploy/`, `scripts/`), application code (`backend/`, `frontend/`), or project files (`**/*.csproj`) auto-trigger CI Extended. Ensure CI Extended is green before merging these PRs.

- For issue execution unless the user explicitly says otherwise: open the PR after verification is complete, then perform a deliberate reviewer-style pass on the PR diff/comments before handoff.

## Output expectations (after work)
Expand Down
Loading