Require ci-extended pass for workflow and infrastructure PRs#642
Require ci-extended pass for workflow and infrastructure PRs#642Chris0Jeky merged 3 commits intomainfrom
Conversation
ci-extended already auto-triggers on workflow, deploy, script, backend, and frontend path changes. Add **/*.csproj so project file changes (which can affect build, dependencies, and infrastructure) also trigger the extended CI lane. Refs #608
Add a checklist item reminding contributors to verify CI Extended passed when their PR touches workflow, infrastructure, or project files. Refs #608
Note in the contributor protocol that PRs touching CI workflows, deploy/scripts config, or .csproj files auto-trigger CI Extended and should have it green before merge. Refs #608
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Self-Review FindingsPath filter correctness: The Existing triggers preserved: The Will this run too often? The Concurrency handling: The existing No issues found -- the change is minimal and safe. |
There was a problem hiding this comment.
Code Review
This pull request updates the pull request template and agent documentation to include instructions for validating the CI Extended workflow. Feedback was provided to include missing directory paths (backend/ and frontend/) and to use a more accurate glob pattern (**/*.csproj) for project files in both the PR template and the agent guidelines.
|
|
||
| ## CI Workflow Validation | ||
|
|
||
| - [ ] If this PR touches `.github/workflows/`, `deploy/`, `scripts/`, or `*.csproj` files: confirm CI Extended passed (auto-triggered on these paths) |
There was a problem hiding this comment.
The list of paths that trigger CI Extended is incomplete. According to the PR summary, backend/ and frontend/ paths also trigger this workflow. Additionally, the glob pattern should be **/*.csproj to accurately reflect that project files in subdirectories (like backend/src/...) are included in the trigger.
| - [ ] If this PR touches `.github/workflows/`, `deploy/`, `scripts/`, or `*.csproj` files: confirm CI Extended passed (auto-triggered on these paths) | |
| - [ ] If this PR touches `.github/workflows/`, `deploy/`, `scripts/`, `backend/`, `frontend/`, or `**/*.csproj` files: confirm CI Extended passed (auto-triggered on these paths) |
| - Pull requests: Provide a short summary, key implementation notes, and testing evidence | ||
| (commands run, screenshots for UI changes). Link related issues/tasks where applicable. | ||
| - Keep PRs focused and small when possible; prefer follow-up PRs for refactors or additional cleanup. | ||
| - PRs touching CI workflows (`.github/workflows/`), infrastructure (`deploy/`, `scripts/`), or project files (`*.csproj`) auto-trigger CI Extended. Ensure CI Extended is green before merging these PRs. |
There was a problem hiding this comment.
This documentation should include backend/ and frontend/ as they also trigger CI Extended according to the PR description. Also, using the explicit glob **/*.csproj is clearer for agents and matches the implementation described in the PR summary.
| - PRs touching CI workflows (`.github/workflows/`), infrastructure (`deploy/`, `scripts/`), or project files (`*.csproj`) auto-trigger CI Extended. Ensure CI Extended is green before merging these PRs. | |
| - PRs touching CI workflows (`.github/workflows/`), infrastructure (`deploy/`, `scripts/`), application code (`backend/`, `frontend/`), or project files (`**/*.csproj`) auto-trigger CI Extended. Ensure CI Extended is green before merging these PRs. |
Summary
**/*.csprojpath trigger toci-extended.ymlso project file changes auto-trigger the extended CI lane (workflow, deploy, scripts, backend, and frontend paths were already covered)AGENTS.mdcontributor protocolCloses #608
Verification
python -c "import yaml; yaml.safe_load(...)"**/*.csprojwith quotes for YAML safety)if:guards on label checks) not affected by path filter additionsTest plan
.csprojfileworkflow_dispatchstill works