Skip to content

Require ci-extended pass for workflow and infrastructure PRs#642

Merged
Chris0Jeky merged 3 commits intomainfrom
ops/608-ci-extended-path-triggers
Mar 31, 2026
Merged

Require ci-extended pass for workflow and infrastructure PRs#642
Chris0Jeky merged 3 commits intomainfrom
ops/608-ci-extended-path-triggers

Conversation

@Chris0Jeky
Copy link
Copy Markdown
Owner

Summary

  • Add **/*.csproj path trigger to ci-extended.yml so project file changes auto-trigger the extended CI lane (workflow, deploy, scripts, backend, and frontend paths were already covered)
  • Add CI Extended validation reminder to PR template checklist
  • Document CI Extended requirement for infrastructure PRs in AGENTS.md contributor protocol

Closes #608

Verification

  • YAML syntax validated via python -c "import yaml; yaml.safe_load(...)"
  • Existing triggers (label-based, manual dispatch) preserved unchanged
  • Path filter uses correct GitHub Actions glob syntax (**/*.csproj with quotes for YAML safety)
  • Conditional job logic (if: guards on label checks) not affected by path filter additions

Test plan

  • Verify CI Extended triggers on a PR that only modifies a .csproj file
  • Verify existing label-triggered jobs (testing, security, automation) still work
  • Verify manual workflow_dispatch still works

ci-extended already auto-triggers on workflow, deploy, script, backend,
and frontend path changes. Add **/*.csproj so project file changes
(which can affect build, dependencies, and infrastructure) also trigger
the extended CI lane.

Refs #608
Add a checklist item reminding contributors to verify CI Extended
passed when their PR touches workflow, infrastructure, or project
files.

Refs #608
Note in the contributor protocol that PRs touching CI workflows,
deploy/scripts config, or .csproj files auto-trigger CI Extended
and should have it green before merge.

Refs #608
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@Chris0Jeky
Copy link
Copy Markdown
Owner Author

Self-Review Findings

Path filter correctness: The **/*.csproj pattern uses GitHub Actions glob syntax correctly -- ** matches any directory depth and *.csproj matches the filename. Quoted in YAML to avoid special character issues.

Existing triggers preserved: The labeled, workflow_dispatch, and other pull_request event types are unchanged. Label-gated jobs (testing, security, automation) use if: conditions that check contains(github.event.pull_request.labels.*.name, ...) -- these are independent of path filters and remain correct.

Will this run too often? The backend/** and frontend/** path filters were already present, so ci-extended already triggers on most code PRs. Adding **/*.csproj is a narrow addition -- .csproj files rarely change outside backend/ (already covered), so the incremental trigger increase is minimal.

Concurrency handling: The existing cancel-in-progress: true concurrency group means rapid pushes won't pile up runs.

No issues found -- the change is minimal and safe.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pull request template and agent documentation to include instructions for validating the CI Extended workflow. Feedback was provided to include missing directory paths (backend/ and frontend/) and to use a more accurate glob pattern (**/*.csproj) for project files in both the PR template and the agent guidelines.


## CI Workflow Validation

- [ ] If this PR touches `.github/workflows/`, `deploy/`, `scripts/`, or `*.csproj` files: confirm CI Extended passed (auto-triggered on these paths)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The list of paths that trigger CI Extended is incomplete. According to the PR summary, backend/ and frontend/ paths also trigger this workflow. Additionally, the glob pattern should be **/*.csproj to accurately reflect that project files in subdirectories (like backend/src/...) are included in the trigger.

Suggested change
- [ ] If this PR touches `.github/workflows/`, `deploy/`, `scripts/`, or `*.csproj` files: confirm CI Extended passed (auto-triggered on these paths)
- [ ] If this PR touches `.github/workflows/`, `deploy/`, `scripts/`, `backend/`, `frontend/`, or `**/*.csproj` files: confirm CI Extended passed (auto-triggered on these paths)

Comment thread AGENTS.md
- Pull requests: Provide a short summary, key implementation notes, and testing evidence
(commands run, screenshots for UI changes). Link related issues/tasks where applicable.
- Keep PRs focused and small when possible; prefer follow-up PRs for refactors or additional cleanup.
- PRs touching CI workflows (`.github/workflows/`), infrastructure (`deploy/`, `scripts/`), or project files (`*.csproj`) auto-trigger CI Extended. Ensure CI Extended is green before merging these PRs.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This documentation should include backend/ and frontend/ as they also trigger CI Extended according to the PR description. Also, using the explicit glob **/*.csproj is clearer for agents and matches the implementation described in the PR summary.

Suggested change
- PRs touching CI workflows (`.github/workflows/`), infrastructure (`deploy/`, `scripts/`), or project files (`*.csproj`) auto-trigger CI Extended. Ensure CI Extended is green before merging these PRs.
- PRs touching CI workflows (`.github/workflows/`), infrastructure (`deploy/`, `scripts/`), application code (`backend/`, `frontend/`), or project files (`**/*.csproj`) auto-trigger CI Extended. Ensure CI Extended is green before merging these PRs.

@Chris0Jeky Chris0Jeky merged commit 722cb77 into main Mar 31, 2026
22 checks passed
@github-project-automation github-project-automation bot moved this from Pending to Done in Taskdeck Execution Mar 31, 2026
@Chris0Jeky Chris0Jeky deleted the ops/608-ci-extended-path-triggers branch March 31, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

OPS-26: Require ci-extended pass for workflow and infrastructure PRs

1 participant