Skip to content

RRPS-8949 Add aria-label to loading spinner #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JHamoni676 merged 3 commits into from
Oct 28, 2025
Merged

RRPS-8949 Add aria-label to loading spinner #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca2ca34
RRPS-8949 Add aria-label to loading spinner
Oct 27, 2025
0de54c0
RRPS-8949 Make loading spinner aria-label customizable
Oct 27, 2025
6e03c27
RRPS-8949 Update aria-label to be a bound attribute
Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/centeva-core/src/components/loading/loading.component.html
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@pdeffendol pdeffendol Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text will be read by a screen reader while navigating the page. Does it make more sense to label it "Loading data, please wait" or something else? "Spinner" is a completely visual concept and won't make sense to a screen reader user.

Copy link
Copy Markdown
Contributor Author

@JHamoni676 JHamoni676 Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the default label text.

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="loading-container">
<div class="loading-text" *ngIf="loadingText">{{loadingText}}</div>
<mat-progress-spinner [color]="loaderColor" mode="indeterminate"></mat-progress-spinner>
<mat-progress-spinner [attr.aria-label]="ariaLabel" [color]="loaderColor" mode="indeterminate"></mat-progress-spinner>
</div>
1 change: 1 addition & 0 deletions projects/centeva-core/src/components/loading/loading.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export class LoadingComponent implements OnInit {

@Input() public loadingText = '';
@Input() public loaderColor = 'primary';
@Input() public ariaLabel: string = 'Loading data, please wait';

constructor() {
}
Expand Down