RRPS-8949 Add aria-label to loading spinner#56
Merged
JHamoni676 merged 3 commits intomasterfrom Oct 28, 2025
Merged
Conversation
maestro957
approved these changes
Oct 27, 2025
pdeffendol
reviewed
Oct 27, 2025
Contributor
There was a problem hiding this comment.
This text will be read by a screen reader while navigating the page. Does it make more sense to label it "Loading data, please wait" or something else? "Spinner" is a completely visual concept and won't make sense to a screen reader user.
Contributor
Author
There was a problem hiding this comment.
I updated the default label text.
Devcon4
reviewed
Oct 27, 2025
| <div class="loading-container"> | ||
| <div class="loading-text" *ngIf="loadingText">{{loadingText}}</div> | ||
| <mat-progress-spinner [color]="loaderColor" mode="indeterminate"></mat-progress-spinner> | ||
| <mat-progress-spinner aria-label="Loading Spinner" [color]="loaderColor" mode="indeterminate"></mat-progress-spinner> |
Collaborator
There was a problem hiding this comment.
Would there ever be a case where a consumer would want to customize the label message? For example to say "Loading x Page/data" etc?
Contributor
Author
There was a problem hiding this comment.
It is now easily customizable
williamchamberlinCenteva
approved these changes
Oct 27, 2025
JHamoni676
deleted the
jonahh-RRPS-8949-add-aria-label-to-loading-spinner
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds aria-label to the loading spinner.
What type of PR is this? (check all applicable)
Related Tickets & Documents
RRPS-8949
Changes Made
Added aria-label to loading spinner.
Quality Checklist