Open
Conversation
mcmcgrath13
requested review from
JordanGuinn and
krista-skylight
and removed request for
a team
krista-skylight
approved these changes
Mar 11, 2026
krista-skylight
left a comment
krista-skylight
left a comment
There was a problem hiding this comment.
Left a non-blocking comment but something I think we should revisit down the line!
emyl3
reviewed
Mar 11, 2026
mcmcgrath13
added a commit
that referenced
this pull request
Mar 12, 2026
## Description In completing #3074 , I found some of the container set up wasn't actually working fully. This PR fixes that: * Add the mssql driver dependencies to the docker container * Use host networking for the integration test container run so both the tests directly and the repot-execution container can talk to the DB using the same `localhost` connection string * Add the `DATABASE_CONN_STRING` env var to the base compose and sample env * Set up the docker compose in integration tests to use the sample env files * Have the integration docker compose use the `--build` flag when setting up containers * Add an integration test to prove it works
…into mcm/spike-custom-py-lib
Contributor
Author
|
Re-requesting review as now I'd like to merge this PR for real |
mcmcgrath13
commented
Mar 12, 2026
| result = json.loads(response.read()) | ||
| assert ( | ||
| result['description'] | ||
| result['header'] |
Contributor
Author
There was a problem hiding this comment.
not specific to this changeset, but lingering bug from PR interaction effect already on main
|
krista-skylight
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR shows that we are able to mount a custom library into the expected location and run that library when the spec indicates that
is_builtin: FalseNotes:
mainas this PR isn't intended for mergeTickets