Conversation
krista-skylight
requested review from
emyl3 and
mcmcgrath13
and removed request for
a team
|
nice catch! docker runs on 8001 and if you use the sample.env, that will push you to 8001 as well. Is there any way to change the default in the app to 8001? |
|
You now need the .env instead of nice-to-have .env due to the DB setup. I left a couple suggestions that make that more clear and then the port will be |
Co-authored-by: Mary McGrath <m.c.mcgrath13@gmail.com>
Co-authored-by: Mary McGrath <m.c.mcgrath13@gmail.com>
apps/report-execution/.gitignore
Outdated
| .pytest_cache/ | ||
| .venv/ No newline at end of file | ||
| .venv/ | ||
| .env No newline at end of file |
There was a problem hiding this comment.
(q, nb): .env should already be ignored based on the top level .gitignore - were you seeing otherwise? (checking my knowledge of how gitignores work)
There was a problem hiding this comment.
Sorry I did this kind of reflexively. You are totally right!
| Sample curl: | ||
| ```sh | ||
| curl -X POST 'http://localhost:8001/report/execute' -H "accept: application/json" -H "Content-Type: application/json" -d '{ | ||
| curl -X POST 'http://localhost:8000/report/execute' -H "accept: application/json" -H "Content-Type: application/json" -d '{ |
There was a problem hiding this comment.
| curl -X POST 'http://localhost:8000/report/execute' -H "accept: application/json" -H "Content-Type: application/json" -d '{ | |
| curl -X POST 'http://localhost:8001/report/execute' -H "accept: application/json" -H "Content-Type: application/json" -d '{ |
| - API: http://localhost:8000 | ||
| - Interactive API docs (Swagger UI): http://localhost:8000/docs | ||
| - Alternative API docs (ReDoc): http://localhost:8000/redoc |
There was a problem hiding this comment.
| - API: http://localhost:8000 | |
| - Interactive API docs (Swagger UI): http://localhost:8000/docs | |
| - Alternative API docs (ReDoc): http://localhost:8000/redoc | |
| - API: http://localhost:8001 | |
| - Interactive API docs (Swagger UI): http://localhost:8001/docs | |
| - Alternative API docs (ReDoc): http://localhost:8001/redoc |
|
2 participants
Description
I spun up this app for my own edification while reviewing Mary's PR and found the port defaulted to 8000, so updating documentation. If we want to use 8001 for a reason, I think we'll need to specify in
.envfile.Checklist before requesting a review