Create starting samurai autogen npc

[tchalvak]

Purpose of PR:

Before

After

For Non-Hotfixes:

Attached Screenshot of my change:

Things that make review take longer:

(remove lines that do not apply to this PR)

• Changing more than 20 files (much harder to review)
• Changing more than 5 files (a bit harder to review)
• Changes to critical code (login, dashboard, etc)
• No comments on changed files
• Tests do not pass (will get pushed back)

Things that make review faster and easier:

(check box with an x where it applies)

• I attached a screenshot of the changed part of the app working
• I added tests
• This feature is requested specifically by a user
• This will fix a bug

Preview results in my branch at the url:

• https://localhost:8765/someUrlHere

[evolua-app]

Code Review Summary

Analysis Results:
1 issues found (0 critical, 1 high, 0 medium, 0 low)

Key Findings (Critical & High):

• Potential undefined constant usage in stealth status check in deploy/lib/control/NpcController.php

Files Analyzed

File Path	Changes	Issues Found
deploy/lib/control/NpcController.php	4	1

---

This analysis was performed by Evolua. For support, please contact our team.

• Email us @ support@evolua.io
• Run: /evolua-review to start a new code review.
• Visit Evolua for more information

[evolua-app]

⚠️ Potential undefined constant usage in stealth status check

The code uses STEALTH as a constant in the condition $player->hasStatus(STEALTH), but there is no visible declaration of this constant in the provided code. If this constant is undefined, it will be interpreted as a string literal 'STEALTH', which might cause the hasStatus check to fail silently, allowing players to maintain stealth status incorrectly when attacking NPCs that should remove it.

Impact

This could lead to gameplay imbalance where players can attack certain NPCs while maintaining stealth when they shouldn't be allowed to. This breaks game mechanics and could potentially be exploited by players.

References

• CWE-676
• PHP Manual - Constants

Recommendation

Either define the STEALTH constant if it's missing, or use a string literal if that's the intended behavior. If the constant is defined elsewhere in the codebase, consider importing it or using a class constant instead for better maintainability.

if ($player->hasStatus(Player::STEALTH) && 
    (in_array(strtolower($victim), self::$STEALTH_REMOVING_NPCS) || ($npco && $npco->hasTrait('stealth_removing')))) {

📝 Suggested fix

‼️ IMPORTANT
Please review this suggestion carefully before applying:

• Verify it matches your codebase standards
• Ensure it doesn't introduce new issues
• Test thoroughly after applying

Suggested change

	if ($player->hasStatus(STEALTH) &&
	(in_array(strtolower($victim), self::$STEALTH_REMOVING_NPCS) || ($npco && $npco->hasTrait('stealth_removing')))) {
	if ($player->hasStatus(Player::STEALTH) &&
	(in_array(strtolower($victim), self::$STEALTH_REMOVING_NPCS) || ($npco && $npco->hasTrait('stealth_removing')))) {

[tchalvak]

Hmmm, I think this is the old “defined globally” constant problem.

[cypress]

NinjaWars Functional Testing    Run #775

Run Properties:   Passed #775  •  4875f63d73 ℹ️: Merge 21c987cb765c1f25831429d7009434bb72fa052e into cd149540000a3d55658830599b5f...

Project	NinjaWars Functional Testing
Branch Review	feat/npm-updates
Run status	Passed #775
Run duration	02m 00s
Commit	4875f63d73 ℹ️: Merge 21c987cb765c1f25831429d7009434bb72fa052e into cd149540000a3d55658830599b5f...
Committer	Coco R
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	0
Skipped	0
Passing	14
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎