Remove python-dotenv and simplify dockerfile building stage#8
Merged
RepoRover merged 3 commits intofeature/versioned-releasesfrom Aug 28, 2025
Merged
Remove python-dotenv and simplify dockerfile building stage#8RepoRover merged 3 commits intofeature/versioned-releasesfrom
RepoRover merged 3 commits intofeature/versioned-releasesfrom
Conversation
- Removed python-dotenv dependency and lines utilizing it. The pydantic_settings managed the environment and should fail on missing dependencies.
- Refactiored the dockerfile to have a pinned version of UV for consistent builds. - Simplified dockerfile by utilizing UV's prebuilt image
There was a problem hiding this comment.
Pull Request Overview
This PR removes the python-dotenv dependency and simplifies the Docker build process by using a pre-built uv image. The changes eliminate explicit environment variable loading from .env files while preserving pydantic-settings' built-in .env file support.
- Removed python-dotenv dependency from pyproject.toml
- Eliminated manual .env loading and BASE_URL validation in config.py
- Simplified Dockerfile by using official uv Alpine image instead of manual installation
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pyproject.toml | Removes python-dotenv dependency |
| database_schema_spec/core/config.py | Removes dotenv import, manual .env loading, and BASE_URL validation |
| Dockerfile | Replaces manual uv installation with official uv image |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Matheus-OAMK
added
chores
RepoRover
approved these changes
Aug 28, 2025
Contributor
RepoRover
left a comment
RepoRover
left a comment
There was a problem hiding this comment.
Well done, looks promising! Let's see this thing fly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.