Conversation
…hem into generated schemas dynamically
…w to create images
…o create staging images
Docker utilisation
This was
linked to
issues
Aug 27, 2025
RepoRover
added
chores
- Removed python-dotenv dependency and lines utilizing it. The pydantic_settings managed the environment and should fail on missing dependencies.
- Refactiored the dockerfile to have a pinned version of UV for consistent builds. - Simplified dockerfile by utilizing UV's prebuilt image
Contributor
Matheus-OAMK
left a comment
Matheus-OAMK
left a comment
There was a problem hiding this comment.
As per my comments. I have opened a PR that addresses these issues
RepoRover
force-pushed
the
feature/versioned-releases
branch
from
ece4232 to
5c6c3d9
Compare
Remove python-dotenv and simplify dockerfile building stage
Matheus-OAMK
approved these changes
Aug 28, 2025
RepoRover
added a commit
that referenced
this pull request
Sep 2, 2025
* Feat/automate unified doc creation (#3) * refactor: Move all files located in the root to a dedicated folder * chore: Setup development tools and packages * refactor/fix: Remove redundant metadata and fix reference from .json documents - Removed `$schema` and `$id` from nested .json documents - Fixed the reference inside the oneOf block for PSQL v15.0 in the file `specs.json` to point to the correct `spec.json` * feat: implement database schema specification generator with conditional resolution Implement a comprehensive database schema specification generator that processes JSON Schema files with conditional oneOf logic for different database engines and versions. ### Core Features **Schema Resolution System:** - Add JSONRefResolver for handling $ref references with circular detection - Implement ConditionalMerger for oneOf conditional logic resolution - Support both if/then and direct property constraint formats - Add VariantExtractor for database variant discovery from oneOf blocks **Validation Framework:** - Add SchemaValidator with JSON Schema Draft 7 compliance checking - Implement custom validation rules for project-specific requirements - Include validation for required fields and schema structure **Logging Infrastructure:** - Add centralized logging configuration with JSON-based setup - Support both console and file handlers with detailed formatting - Include queue-based logging for performance **CLI Generator:** - Implement SchemaGenerator for end-to-end schema processing - Support multiple database variants (PostgreSQL, MySQL) - Generate resolved schemas without oneOf conditionals * feat: Add generation of all available files in .json format to `output/vmap.json` - Introduced new functionality to generate a .json file that maps all available engines and their corresponndiing versions to an url. The map is saved in the output folder in a singleton file. - Introduced a new configuration module to manage application settings. - Added support for loading configuration from a .env file. - Updated the schema generator and output manager to utilize the new config. - Created example .env file and updated README with configuration instructions. - Implemented tests for configuration handling and output manager functionality. * feat: Add CI workflow and setup actions for Python and uv * Feature/versioned releases (#6) * fix: enforce required environment variables in configuration & pass them into generated schemas dynamically * fix: reorder top-level keys in generated schemas to prioritize $id and $schema fields * fix: moved description field from snapshot to schema definition * fix: enable overriding of environment variables when loading .env file * feat: add Dockerfile, .dockerignore for schema generation and workflow to create images * feat: added workflow to create production images & cleaned workflow to create staging images * refactor(config): Remove unecessary python-dotenv dependency - Removed python-dotenv dependency and lines utilizing it. The pydantic_settings managed the environment and should fail on missing dependencies. * refactor(Dockerfile): Pin UV version and simplify building stage - Refactiored the dockerfile to have a pinned version of UV for consistent builds. - Simplified dockerfile by utilizing UV's prebuilt image * refactor(config): Remove leftover comments --------- Co-authored-by: Matheus-OAMK <t2fema00@students.oamk.fi> * feat: consolidate CI/CD workflows by creating service version images and removing staging image workflow (#9) * feat: consolidate CI/CD workflows by creating service version images and removing staging image workflow * feat: remove staging branch from CI workflow triggers --------- Co-authored-by: Matheus Oliveira <t2fema00@students.oamk.fi>
RepoRover
added a commit
that referenced
this pull request
Dec 10, 2025
* Feat/automate unified doc creation (#3) * refactor: Move all files located in the root to a dedicated folder * chore: Setup development tools and packages * refactor/fix: Remove redundant metadata and fix reference from .json documents - Removed `$schema` and `$id` from nested .json documents - Fixed the reference inside the oneOf block for PSQL v15.0 in the file `specs.json` to point to the correct `spec.json` * feat: implement database schema specification generator with conditional resolution Implement a comprehensive database schema specification generator that processes JSON Schema files with conditional oneOf logic for different database engines and versions. ### Core Features **Schema Resolution System:** - Add JSONRefResolver for handling $ref references with circular detection - Implement ConditionalMerger for oneOf conditional logic resolution - Support both if/then and direct property constraint formats - Add VariantExtractor for database variant discovery from oneOf blocks **Validation Framework:** - Add SchemaValidator with JSON Schema Draft 7 compliance checking - Implement custom validation rules for project-specific requirements - Include validation for required fields and schema structure **Logging Infrastructure:** - Add centralized logging configuration with JSON-based setup - Support both console and file handlers with detailed formatting - Include queue-based logging for performance **CLI Generator:** - Implement SchemaGenerator for end-to-end schema processing - Support multiple database variants (PostgreSQL, MySQL) - Generate resolved schemas without oneOf conditionals * feat: Add generation of all available files in .json format to `output/vmap.json` - Introduced new functionality to generate a .json file that maps all available engines and their corresponndiing versions to an url. The map is saved in the output folder in a singleton file. - Introduced a new configuration module to manage application settings. - Added support for loading configuration from a .env file. - Updated the schema generator and output manager to utilize the new config. - Created example .env file and updated README with configuration instructions. - Implemented tests for configuration handling and output manager functionality. * feat: Add CI workflow and setup actions for Python and uv * Feature/versioned releases (#6) * fix: enforce required environment variables in configuration & pass them into generated schemas dynamically * fix: reorder top-level keys in generated schemas to prioritize $id and $schema fields * fix: moved description field from snapshot to schema definition * fix: enable overriding of environment variables when loading .env file * feat: add Dockerfile, .dockerignore for schema generation and workflow to create images * feat: added workflow to create production images & cleaned workflow to create staging images * refactor(config): Remove unecessary python-dotenv dependency - Removed python-dotenv dependency and lines utilizing it. The pydantic_settings managed the environment and should fail on missing dependencies. * refactor(Dockerfile): Pin UV version and simplify building stage - Refactiored the dockerfile to have a pinned version of UV for consistent builds. - Simplified dockerfile by utilizing UV's prebuilt image * refactor(config): Remove leftover comments --------- Co-authored-by: Matheus-OAMK <t2fema00@students.oamk.fi> * feat: consolidate CI/CD workflows by creating service version images and removing staging image workflow (#9) * feat: consolidate CI/CD workflows by creating service version images and removing staging image workflow * feat: remove staging branch from CI workflow triggers --------- Co-authored-by: Matheus Oliveira <t2fema00@students.oamk.fi>
RepoRover
added a commit
that referenced
this pull request
Dec 10, 2025
…djusted the schema spec generation logic * Feat/automate unified doc creation (#3) * refactor: Move all files located in the root to a dedicated folder * chore: Setup development tools and packages * refactor/fix: Remove redundant metadata and fix reference from .json documents - Removed `$schema` and `$id` from nested .json documents - Fixed the reference inside the oneOf block for PSQL v15.0 in the file `specs.json` to point to the correct `spec.json` * feat: implement database schema specification generator with conditional resolution Implement a comprehensive database schema specification generator that processes JSON Schema files with conditional oneOf logic for different database engines and versions. ### Core Features **Schema Resolution System:** - Add JSONRefResolver for handling $ref references with circular detection - Implement ConditionalMerger for oneOf conditional logic resolution - Support both if/then and direct property constraint formats - Add VariantExtractor for database variant discovery from oneOf blocks **Validation Framework:** - Add SchemaValidator with JSON Schema Draft 7 compliance checking - Implement custom validation rules for project-specific requirements - Include validation for required fields and schema structure **Logging Infrastructure:** - Add centralized logging configuration with JSON-based setup - Support both console and file handlers with detailed formatting - Include queue-based logging for performance **CLI Generator:** - Implement SchemaGenerator for end-to-end schema processing - Support multiple database variants (PostgreSQL, MySQL) - Generate resolved schemas without oneOf conditionals * feat: Add generation of all available files in .json format to `output/vmap.json` - Introduced new functionality to generate a .json file that maps all available engines and their corresponndiing versions to an url. The map is saved in the output folder in a singleton file. - Introduced a new configuration module to manage application settings. - Added support for loading configuration from a .env file. - Updated the schema generator and output manager to utilize the new config. - Created example .env file and updated README with configuration instructions. - Implemented tests for configuration handling and output manager functionality. * feat: Add CI workflow and setup actions for Python and uv * Feature/versioned releases (#6) * fix: enforce required environment variables in configuration & pass them into generated schemas dynamically * fix: reorder top-level keys in generated schemas to prioritize $id and $schema fields * fix: moved description field from snapshot to schema definition * fix: enable overriding of environment variables when loading .env file * feat: add Dockerfile, .dockerignore for schema generation and workflow to create images * feat: added workflow to create production images & cleaned workflow to create staging images * refactor(config): Remove unecessary python-dotenv dependency - Removed python-dotenv dependency and lines utilizing it. The pydantic_settings managed the environment and should fail on missing dependencies. * refactor(Dockerfile): Pin UV version and simplify building stage - Refactiored the dockerfile to have a pinned version of UV for consistent builds. - Simplified dockerfile by utilizing UV's prebuilt image * refactor(config): Remove leftover comments --------- * feat: consolidate CI/CD workflows by creating service version images and removing staging image workflow (#9) * feat: consolidate CI/CD workflows by creating service version images and removing staging image workflow * feat: remove staging branch from CI workflow triggers --------- Co-authored-by: Matheus Oliveira <t2fema00@students.oamk.fi>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new Docker-based build and release workflow for the database schema spec generator, along with improvements to schema output structure, configuration management, and example/documentation consistency. The changes enable automated production and staging image builds, enforce environment variable requirements, and update the schema specification to improve clarity and validation.
CI/CD and Docker Integration:
.github/workflows/create-prod-image.yamland.github/workflows/create-staging-image.yamlto automate Docker image builds and pushes for production (on release tags) and staging (on release candidate tags). These workflows run quality checks, extract metadata, build/push images to GHCR, and manage build caches. [1] [2]Dockerfilethat builds the schema spec generator, installs dependencies withuv, runs schema generation, and produces a lightweight final image containing only the output..dockerignoreto exclude development, build, and CI/CD files from Docker image context, improving build efficiency and image cleanliness.Schema Specification and Output Improvements:
unified_schema.jsontospec.jsonfor clarity and consistency.$idfield based on the configuredBASE_URL, and reordered top-level keys so$idappears immediately after$schemawhen present, improving schema discoverability and compliance.docs/schemas/base/schema.json) to move thedescriptionfield fromsnapshotto the top-level schema object, require it, and remove it fromsnapshot. This clarifies the meaning and location of schema descriptions and updates required fields. [1] [2] [3]descriptionto the top-level and removing it fromsnapshot. [1] [2] [3]$idfield fromspecs.jsonand PostgreSQL engine spec JSON, as it is now dynamically injected during generation. [1] [2]Configuration and Environment Handling:
BASE_URLenvironment variable at application startup, raising a clear error if missing, and loaded environment variables from.envusingdotenvfor improved testability and reliability. [1] [2] [3]