[.NET] Fix missing DataSource serialization in DiscoveredAssetManagementGroup.ToProtocol()#1204
Merged
timtay-microsoft merged 3 commits intomainfrom Feb 4, 2026
Merged
[.NET] Fix missing DataSource serialization in DiscoveredAssetManagementGroup.ToProtocol()#1204timtay-microsoft merged 3 commits intomainfrom
timtay-microsoft merged 3 commits intomainfrom
Conversation
…entGroup.ToProtocol() This pull request introduces a minor update to the protocol conversion logic for asset management groups. The main change is the inclusion of the `DataSource` property when converting to the protocol model, ensuring that this information is now correctly transferred. * Protocol conversion update: * Added mapping of the `DataSource` property from the source object to the protocol object in the `ToProtocol` method in `ProtocolConverter.cs`. Authored by @koepalex
timtay-microsoft
requested review from
avishekpant,
maximsemenov80 and
olivakar
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a missing property serialization in the DiscoveredAssetManagementGroup.ToProtocol() method by adding the DataSource property mapping, ensuring complete data transfer when converting to the protocol model.
Changes:
- Added
DataSourceproperty mapping in theToProtocolmethod forDiscoveredAssetManagementGroup, bringing it in line with similar conversion methods forDiscoveredAssetEventGroup,DiscoveredAssetEvent,DiscoveredAssetDataset, andDiscoveredAssetDatasetDataPoint.
maximsemenov80
approved these changes
Feb 4, 2026
timtay-microsoft
added a commit
that referenced
this pull request
Feb 4, 2026
protocol: - Various cloud event validation fixes (#1166) - Allow subject + time to be omitted from a cloud event (#1167) - Remove duplicated addition of timestamp user property when invoking a command (#1169) services: - Fix discovered asset class not mapping externalAssetId, displayName, or description fields (#1180) - Fix missing DataSource serialization in DiscoveredAssetManagementGroup.ToProtocol() (#1204)
timtay-microsoft
added a commit
that referenced
this pull request
Feb 4, 2026
protocol: - Various cloud event validation fixes (#1166) - Allow subject + time to be omitted from a cloud event (#1167) - Remove duplicated addition of timestamp user property when invoking a command (#1169) services: - Fix discovered asset class not mapping externalAssetId, displayName, or description fields (#1180) - Fix missing DataSource serialization in DiscoveredAssetManagementGroup.ToProtocol() (#1204) connector: - Propagate cancellation token within connector worker async methods (#1207)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a minor update to the protocol conversion logic for asset management groups. The main change is the inclusion of the
DataSourceproperty when converting to the protocol model, ensuring that this information is now correctly transferred.DataSourceproperty from the source object to the protocol object in theToProtocolmethod inProtocolConverter.cs.Authored by @koepalex via #1203