Fix missing DataSource serialization in DiscoveredAssetManagementGroup.ToProtocol()#1203
Closed
koepalex wants to merge 1 commit intoAzure:mainfrom
Closed
Conversation
koepalex
requested review from
avishekpant,
maximsemenov80,
olivakar and
timtay-microsoft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a missing property serialization issue in the DiscoveredAssetManagementGroup.ToProtocol() method. The DataSource property was not being mapped during the protocol conversion, which could result in data loss when converting between the model and protocol representations.
Changes:
- Added the missing
DataSourceproperty mapping in theToProtocolmethod forDiscoveredAssetManagementGroup
varunpuranik
reviewed
Feb 4, 2026
varunpuranik
left a comment
varunpuranik
left a comment
There was a problem hiding this comment.
LGTM.
@timtay-microsoft - can you pls take a look as well? Thanks!
Member
|
The change LGTM as well. Our pipelines don't work with forks of our repo though, so I'll open PR #1204 to merge this from a branch in this repo |
timtay-microsoft
added a commit
that referenced
this pull request
Feb 4, 2026
…entGroup.ToProtocol() (#1204) This pull request introduces a minor update to the protocol conversion logic for asset management groups. The main change is the inclusion of the `DataSource` property when converting to the protocol model, ensuring that this information is now correctly transferred. Authored by @koepalex via #1203
Member
|
Closing in favor of #1204 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a minor update to the protocol conversion logic for asset management groups. The main change is the inclusion of the
DataSourceproperty when converting to the protocol model, ensuring that this information is now correctly transferred.DataSourceproperty from the source object to the protocol object in theToProtocolmethod inProtocolConverter.cs.