Skip to content
This repository was archived by the owner on Aug 27, 2018. It is now read-only.

Fix assignment to undeclared variable in state #283

Open
blowery wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix assignment to undeclared variable in state #283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/state/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const init = ({ customEnhancer, customMiddleware = {} } = {}) => {
const middle = withMiddleware(customMiddleware);
const create = customEnhancer ? customEnhancer(middle) : middle;

store = create(reducer, reducer(undefined, { type: '@@INIT' }));
const store = create(reducer, reducer(undefined, { type: '@@INIT' }));
Copy link
Member

@dmsnell dmsnell Jun 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brought in in https://github.com/Automattic/notifications-panel/pull/108/files#diff-1dabc0c5cbcbadc986b3d7e221b63734

maybe it would be more in the spirit of the original code change to just return create( … ). I don't see any need for the store to have its own binding.


return store;
};
Expand Down