This repository was archived by the owner on Aug 27, 2018. It is now read-only.
Fix assignment to undeclared variable in state#283
Open
Conversation
dmsnell
reviewed
Jun 22, 2018
| const create = customEnhancer ? customEnhancer(middle) : middle; | ||
|
|
||
| store = create(reducer, reducer(undefined, { type: '@@INIT' })); | ||
| const store = create(reducer, reducer(undefined, { type: '@@INIT' })); |
Member
There was a problem hiding this comment.
brought in in https://github.com/Automattic/notifications-panel/pull/108/files#diff-1dabc0c5cbcbadc986b3d7e221b63734
maybe it would be more in the spirit of the original code change to just return create( … ). I don't see any need for the store to have its own binding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this when trying to compile calypso with some more modern babel presets. Once "use strict" is added to the file, this throws.