Skip to content

fix: add space to donate block label in editor #2270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laurelfulford merged 4 commits into from
Jan 6, 2026
Merged

fix: add space to donate block label in editor #2270

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12b086c
fix: add space to donate block label in editor
laurelfulford Jan 6, 2026
c0d5b88
fix: correcting linting errors
laurelfulford Jan 6, 2026
5c7a6f4
fix: correct prettier errors
laurelfulford Jan 6, 2026
0b8d7e2
fix: removing something autocomplete snuck
laurelfulford Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/blocks/donate/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,12 @@ export const getFrequencyLabel = ( frequencySlug: DonationFrequencySlug, hideOnc
? hideOnceLabel
? ''
: __( 'once', 'newspack-blocks' )
: sprintf(
// Translators: %s is the frequency (e.g. per month, per year).
_x( 'per %s', 'per `Frequency`', 'newspack-blocks' ),
frequencySlug
);
: ' ' +
Copy link
Contributor

@chickenn00dle chickenn00dle Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I wonder if this is friendly for all languages? I'm just guessing there might be languages where forcing the frequency string to come after the amount string will result in some potentially funky translations.

Maybe it would be better to add the frequency within the getFormattedAmmount method below so we can generate these translated strings consistently?

WDYT?

Copy link
Contributor

@chickenn00dle chickenn00dle Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this is the case already before this PR, so I'll go ahead and approve. But I do think this is a good chance to address this.

Copy link
Contributor Author

@laurelfulford laurelfulford Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chickenn00dle!

Hmm, I wonder if this is friendly for all languages? I'm just guessing there might be languages where forcing the frequency string to come after the amount string will result in some potentially funky translations.

Yeah, that's a good call! I made myself a separate issue to look at this a little closer (NPPM-2509) 🙂 I also see there's a separate getFrequencyLabelWithAmount const that possibly has the same missing space issue (and order issue - I'm not sure yet! This is the first time I've noticed this change).

sprintf(
// Translators: %s is the frequency (e.g. per month, per year).
_x( 'per %s', 'per `Frequency`', 'newspack-blocks' ),
frequencySlug
);
};

export const getFormattedAmount = ( amount: number, withCurrency = false ) => {
Expand Down