fix: add space to donate block label in editor #2270
Conversation
| _x( 'per %s', 'per `Frequency`', 'newspack-blocks' ), | ||
| frequencySlug | ||
| ); | ||
| : ' ' + |
There was a problem hiding this comment.
Hmm, I wonder if this is friendly for all languages? I'm just guessing there might be languages where forcing the frequency string to come after the amount string will result in some potentially funky translations.
Maybe it would be better to add the frequency within the getFormattedAmmount method below so we can generate these translated strings consistently?
WDYT?
There was a problem hiding this comment.
I realize this is the case already before this PR, so I'll go ahead and approve. But I do think this is a good chance to address this.
There was a problem hiding this comment.
Thanks @chickenn00dle!
Hmm, I wonder if this is friendly for all languages? I'm just guessing there might be languages where forcing the frequency string to come after the amount string will result in some potentially funky translations.
Yeah, that's a good call! I made myself a separate issue to look at this a little closer (NPPM-2509) 🙂 I also see there's a separate getFrequencyLabelWithAmount const that possibly has the same missing space issue (and order issue - I'm not sure yet! This is the first time I've noticed this change).
|
Hey @laurelfulford, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
# [4.21.0-alpha.1](v4.20.1...v4.21.0-alpha.1) (2026-01-09) ### Bug Fixes * add Link to express payment array ([#2266](#2266)) ([fdd6fd5](fdd6fd5)) * add space to donate block label in editor ([#2270](#2270)) ([d18cf42](d18cf42)) ### Features * improve express checkout handling by surfacing errors ([#2273](#2273)) ([1d98b9b](1d98b9b))
|
🎉 This PR is included in version 4.21.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
I noticed this while working on something else:
The Donate block has a new per month/per year frequency text in the "Other" field label, but there's no space before this label in the editor. This PR fixes that.
How to test the changes in this Pull Request:
npm run build.Other information: