Fix title and description allignment for mobile screen resolved close…#9
Open
anujkumardarji wants to merge 5 commits intoArvindParekh:mainfrom
Open
Conversation
ArvindParekh
requested changes
May 10, 2024
Owner
|
Thanks for the PR @anujkumardarji and sorry for getting back late, was caught up. I like the approach, however, I think we can still use the available tailwind breakpoints to solve this. Another issue with this approach is that it still does not solve the alignment issue for widths 600-1000px. I think utilizing tailwind breakpoints can help, I left a few comments. Thanks 👍🏻 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ub.com:anujkumardarji/Lofi-Music-App into feature/7-fix-title-and-description-allignment
Author
|
@ArvindParekh Hello, how have you been! I have made some changes and used tailwind for minimal code changes. please review and let me know if further changes are required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title and description are now aligned for better consistency in UI