atcommander: force out of bootload mode, Python3 compatible #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeclement
changed the title
The radio occasionally gets stuck in bootloader mode. This patch replicates a solution from ardupilot (libraries/GCS_MAVLink/GCS_Common.cpp) to unstick the radio. The solution is incorporated into the --force option, making it more assertive than before. This patch also slightly adjusts some of the radio response timeouts.
mikeclement
force-pushed
the
mc_atc_unstick
branch
4 times, most recently
from
b29cec0 to
a59a5df
Compare
This patch contains several changes to make both the API and CLI more consistent as well as minor code cleanup, including: - Added param 15 (MAX_WINDOW) - Moved CLI-only module imports into "if __name__ ..." section - Allow user-specified serial read timeout - Always enter command mode in "local" mode - Added "__" to class data members - Class methods now have consistent return values: - Methods that "do" things return True or False - Methods that return data either return that data or None - Exceptions should be handled within class methods - Int/float queries support negative numbers - Exact query supports re patterns and strips trailing newline - 1-second waits for entering command mode are properly set - Slightly more aggressive ATO and ATZ usage - get_radio_version() handles trailing non-numeric characters (hattip github user mw46d for fixing this a different way) - Consistent CLI exit codes that report all interesting errors - Shortened CLI arguments for list and set operations - Several CLI operations are implicitly retried - Radio parameters are listed using the same names used to set them - Indenting and trailing whitespace cleaned up
mikeclement
force-pushed
the
mc_atc_unstick
branch
from
a59a5df to
9084990
Compare
kaklik
referenced
this pull request
in ThunderFly-aerospace/SiK
Nov 6, 2022
atcommander: force out of bootload mode, Python3 compatible #22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The radio occasionally gets stuck in bootloader mode. This patch replicates
a solution from ardupilot (libraries/GCS_MAVLink/GCS_Common.cpp) to unstick
the radio. The solution is incorporated into the --force option, making it
more assertive than before.
This patch also slightly adjusts some of the radio response timeouts to make the code more responsive overall.
Finally, Michael Day added Python3 compatibility.