Fix BackstageView popout issues: window closing logic, missing icon, and code cleanup#3671
Open
MostafaElsehy wants to merge 3 commits intoArduPilot:masterfrom
Open
Fix BackstageView popout issues: window closing logic, missing icon, and code cleanup#3671MostafaElsehy wants to merge 3 commits intoArduPilot:masterfrom
MostafaElsehy wants to merge 3 commits intoArduPilot:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes BackstageView pop-out issues: ghost windows remaining after navigation, missing application icon on pop-out windows, and general code cleanup.
Changes:
- Added logic to close pop-out windows when navigating away to prevent ghost windows
- Added icon assignment to pop-out forms with a Windows-specific fallback
- Cleaned up whitespace, comments, and formatting
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
This PR addresses Issue #3633 regarding the "pop-out" functionality in the Configuration/Setup screens (BackstageView).
Issues fixed:
Solution
ActivatePageinBackstageView.csto check if the requested page is currently hosted in an external form. If so, the parent form is closed before re-docking the content.lnkButton_DoubleClickto assign the application icon to the new form. Included a fallback mechanism usingIcon.ExtractAssociatedIcon(wrapped in a preprocessor directive to maintain cross-platform compatibility).Testing Steps
Screenshots