Open
Conversation
Investigate other means of stacking
matchups object doesn't currently work. Problem at L308
Help from Gemini 3 to switch over to duckdb for big, out of memory join process. Made some helpers and moved to another file. Haven't thoroughly tested all of match_siteSR_to_WQP yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Matt!
The goal of this PR is to get the siteSR and lakeSR functionality all drafted up. It covers a lot of ground, but I've tried to lay it all out in the vignettes, so hopefully that will act as a good guide. Here's a quick overview:
download_lakeSR(),download_siteSR()addedbuild_sr()added to stack mission-level components of SR datasets. Uses {arrow} Tables, in-memory for nowmatch_siteSR_to_WQP()added. Uses {arrow}, {duckdb}, and parquet files to do matchups outside of memory because of their sizeapply_handoffs()added. Also happens with parquet outside of memoryR/utils-pipe.R,R/globals.R,R/helpers.Radded for behind-the-scenes needsvignettes/example-workflow.Rmd. This one should work locally for you if you want to give it a shot to see how the package works from start to finish. I've run it successfully on 32 GB and 64 GB machines.Thanks!
Closes #2