Skip to content

Conversation

@bharvey88
Copy link
Contributor

@bharvey88 bharvey88 commented Dec 7, 2025

Version:

What does this implement/fix?

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

Summary by CodeRabbit

  • New Features

    • Added logger configuration and dashboard import blocks to ESPHome AIR-1_BLE, enabling GitHub-based package imports for home automation dashboard integration.
  • Chores

    • Updated ESPHome Core version to 25.8.6.1.
    • Updated build workflow firmware naming configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 7, 2025

Walkthrough

Configuration updates across build workflow and ESPHome device definitions: firmware-names mapping parameter renamed in CI/CD workflow, logger and dashboard-import configuration blocks added to AIR-1 BLE device file, and version number incremented in core ESPHome configuration.

Changes

Cohort / File(s) Summary
Build workflow
.github/workflows/build.yml
Updated firmware-names mapping key from "Factory:firmware" to "1_Factory:firmware" for AIR-1 factory configuration association.
ESPHome device configuration
Integrations/ESPHome/AIR-1_BLE.yaml
Added top-level logger block and dashboard_import block with GitHub package URL and import_full_config: false setting.
ESPHome core configuration
Integrations/ESPHome/Core.yaml
Updated version substitution from "25.6.24.1" to "25.8.6.1".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Workflow parameter rename: straightforward single-line change; verify the new key references the correct configuration
  • Dashboard import addition: confirm URL path and import settings are correct for ESPHome package management
  • Version bump: validate the new version aligns with release notes and dependencies

Poem

🐰 The build now names its factory right,
With dashboards poised for import flight,
Versions climb from .24 to .6,
Configuration's newest fix!
Hop along, the workflow's bright! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main purpose of the PR—merging the main branch into beta for synchronization before beta work.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch main

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c3ca903 and 28d9be0.

📒 Files selected for processing (3)
  • .github/workflows/build.yml (1 hunks)
  • Integrations/ESPHome/AIR-1_BLE.yaml (1 hunks)
  • Integrations/ESPHome/Core.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (90)
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
🔇 Additional comments (3)
Integrations/ESPHome/Core.yaml (1)

3-3: Version increment looks good.

Straightforward update from 25.6.24.1 to 25.8.6.1 following the apparent date-based versioning scheme. No functional changes.

.github/workflows/build.yml (1)

29-29: Verify firmware-names mapping still resolves correctly after prefix change.

The firmware-names mapping was changed from "_Factory:firmware" to "1_Factory:firmware". Given that the input yaml file is AIR-1_Factory.yaml (line 28), ensure that the new 1_Factory key still correctly matches and maps to the expected firmware artifact. The old underscore prefix appeared to match the _Factory suffix in the filename; verify the new 1_Factory prefix aligns with the reusable workflow's resolution logic.

Integrations/ESPHome/AIR-1_BLE.yaml (1)

31-35: Configuration additions are clean and appropriate.

The empty logger: block will use ESPHome's default logger settings, and the dashboard_import: block correctly configures this file as a packagable import with import_full_config: false to prevent full config override. These additions align well with the file's role as a BLE variant configuration.


Comment @coderabbitai help to get the list of available commands and usage tips.

@TrevorSchirmer TrevorSchirmer merged commit 017a01d into beta Dec 18, 2025
382 of 384 checks passed
@bharvey88
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants