Skip to content

Conversation

@bharvey88
Copy link
Contributor

@bharvey88 bharvey88 commented Dec 18, 2025

Version: 2025.12.18.2

What does this implement/fix?

Fixes Missing ids for mics entities and changes update_interval back to 60 second esphome defaults

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

Summary by CodeRabbit

  • Updates

    • Core version bumped to 25.12.18.2
  • Chores

    • Added explicit identifiers for SEN55 temperature and humidity sensors
    • Added explicit identifiers for multiple air quality sensors (nitrogen dioxide, carbon monoxide, hydrogen, ethanol, methane, ammonia)
    • Adjusted ammonia sensor update frequency to 60 seconds

✏️ Tip: You can customize this high-level summary in your review settings.

…to 60 second esphome defaults

Fixed missing ids for mics entities and changed update_interval back to 60 second esphome defaults
@coderabbitai
Copy link

coderabbitai bot commented Dec 18, 2025

Walkthrough

Version bump from 25.8.6.1 to 25.12.18.2 with added explicit sensor IDs for SEN55 temperature/humidity and MICS4514 gas sensors (nitrogen dioxide, carbon monoxide, hydrogen, ethanol, methane, ammonia). Ammonia sensor update interval changed to 60 seconds.

Changes

Cohort / File(s) Change Summary
ESPHome Core Configuration
Integrations/ESPHome/Core.yaml
Version bumped from 25.8.6.1 to 25.12.18.2; Added id fields to SEN55 temperature and humidity sensors; Added id fields to MICS4514 sensors (nitrogen_dioxide, carbon_monoxide, hydrogen, ethanol, methane, ammonia); Changed ammonia update_interval from 10s to 60s.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Simple configuration updates with repetitive pattern of adding sensor IDs
  • Single file modified with no complex logic or interdependencies
  • Single parameter value change easily verifiable

Possibly related PRs

Suggested reviewers

  • TrevorSchirmer

Poem

🐰 IDs and versions dance with care,
Sensors now have names so rare,
Ammonia counts slower, tick by tick,
A config fix both clean and slick!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: adding missing IDs to mics entities and updating the ammonia sensor's update_interval from 10s to 60s (ESPHome default).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch mics-missing-ids-update-interval

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 28d9be0 and 4e206fc.

📒 Files selected for processing (1)
  • Integrations/ESPHome/Core.yaml (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_Factory.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1.yaml
  • GitHub Check: Building Integrations/ESPHome/AIR-1_BLE.yaml
🔇 Additional comments (3)
Integrations/ESPHome/Core.yaml (3)

3-3: LGTM! Version bump is correct.

The version format follows the expected YY.MM.DD.# convention and aligns with the PR date.


240-246: LGTM! Sensor IDs added correctly.

The explicit IDs for SEN55 temperature and humidity sensors enable proper referencing of these entities elsewhere in the configuration.


314-330: ID additions are correct and update_interval matches ESPHome documentation.

The ID additions for all MICS4514 gas sensors properly fix the missing IDs. The update_interval of 60s is consistent with ESPHome's example configuration for the MICS4514 platform and aligns with community implementations.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bharvey88 bharvey88 changed the base branch from main to beta December 18, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants