rsyslog: fix truncate_multiline config #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jclarysse
force-pushed
the
jclarysse/feat-rsyslog-sender-multiline-support-2
branch
2 times, most recently
from
9ee571d to
5965ce6
Compare
New JSON setting `truncate_multiline` added as part of previous PR#180 should be a boolean not a string. Also added documentation.
jclarysse
force-pushed
the
jclarysse/feat-rsyslog-sender-multiline-support-2
branch
from
5965ce6 to
615ac1d
Compare
jclarysse
added a commit
to jclarysse/journalpump
that referenced
this pull request
Dec 15, 2025
The recently added config `truncate_multiline`(PR Aiven-Open#180 and Aiven-Open#181) might raise wrong user expectation as it relies on a workaround that is not supported by all syslog servers. I propose to keep this dev but rename the config to `octet_counted_framing` which is what it actually does, and inverse the value. This should avoid confusion and prevent any future misuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON setting
truncate_multilinepreviously added as part of PR #180 should be a boolean not a string.Also added its documentation.