rsyslog: replace conf truncate_multiline by octet_counted_framing #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jclarysse
changed the title
The recently added config `truncate_multiline`(PR Aiven-Open#180 and Aiven-Open#181) might raise wrong user expectation as it relies on a workaround that is not supported by all syslog servers. I propose to keep this dev but rename the config to `octet_counted_framing` which is what it actually does, and inverse the value. This should avoid confusion and prevent any future misuse.
jclarysse
force-pushed
the
jclarysse/feat-rsyslog-sender-multiline-support-3
branch
from
8c520cd to
6317954
Compare
jclarysse
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently added config
truncate_multiline(PR #180 and #181 ) might raise wrong user expectation as it relies on a workaround that is not supported by all syslog servers.I propose to keep this dev but rename the config to
octet_counted_framingwhich is what it actually does, and inverse the value. This should avoid confusion and prevent any future misuse.