Fix: Increase spinner array size for GCC 14/15 compatibility #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR fixes a compilation error on newer Linux distributions using GCC 14 or 15. The spinner array was initialized with 4 characters, but the array size was explicitly set to [4]. Modern GCC versions treat this as a fatal error because there is no room for the null terminator (\0). Increasing the array size from 4 to 5 to accommodate the null terminator allows the build to complete on modern systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes a compilation error on newer Linux distributions using GCC 14 or 15.
The spinner array was initialized with 4 characters, but the array size was explicitly set to [4]. Modern GCC versions treat this as a fatal error because there is no room for the null terminator (\0), and the build dies.
Increasing the array size from 4 to 5 to accommodate the null terminator allows the build to complete on modern systems.