Fix: resolve build errors #11
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial motivation for this PR was to resolve compiler warnings, which are promoted to errors, which cause the build to fail. I ended up also fixing a couple issues with some of the tests (other issues still remain).
ais_charset.c,interactive.c, anduat_decode.chad character arrays initialized without a null terminator. GCC's proposed fix is not portable to clang, so I've removed the hard-coded array length. Both compilers seem to be satisfied with this. (See also, Fix: Increase spinner array size for GCC 14/15 compatibility #10)resingeomag.cwas not being used. I've added appropriate checks to use the value as intended.globe_index.cwere being written, but never read. I've removed the lines of code in question.setExitsymbol being missing, so I've added a stubbed version for the tests.Makefilefor ergonomicsTested on the following setup:
Full disclosures: